Skip to content

[lzo] Fix for building Linux shared library#10451

Merged
dan-shaw merged 3 commits intomicrosoft:masterfrom
here-mikelley:lzo_shared_lib_fix
Mar 28, 2020
Merged

[lzo] Fix for building Linux shared library#10451
dan-shaw merged 3 commits intomicrosoft:masterfrom
here-mikelley:lzo_shared_lib_fix

Conversation

@here-mikelley
Copy link
Copy Markdown
Contributor

@here-mikelley here-mikelley commented Mar 18, 2020

Describe the pull request

  • What does your PR fix? Fixes issue #

Allows you to compile lzo as a shared object under Linux

  • Which triplets are supported/not supported? Have you updated the CI baseline?

All triplets

Yes

PhoebeHui
PhoebeHui suggested changes Mar 18, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the Version to '2.10-5' in CONTROL file?

ports/lzo/portfile.cmake Outdated
file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/share)

if(VCPKG_LIBRARY_LINKAGE STREQUAL dynamic)
if(MSVC AND VCPKG_LIBRARY_LINKAGE STREQUAL dynamic)
Copy link
Copy Markdown
Contributor

@PhoebeHui PhoebeHui Mar 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you replace 'MSVC' with 'VCPKG_TARGET_IS_WINDOWS' ?

Copy link
Copy Markdown
Contributor Author

@here-mikelley here-mikelley Mar 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I was looking for the proper variable to check! :)

@PhoebeHui
Copy link
Copy Markdown
Contributor

PhoebeHui commented Mar 20, 2020 •
edited
Loading

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Mar 20, 2020

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@PhoebeHui PhoebeHui added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed waiting for response labels Mar 20, 2020
@PhoebeHui PhoebeHui marked this pull request as ready for review March 20, 2020 06:20
@PhoebeHui
Copy link
Copy Markdown
Contributor

PhoebeHui commented Mar 20, 2020

@here-mikelley, I guess this PR ready for review? I updated the status.

@here-mikelley
Copy link
Copy Markdown
Contributor Author

here-mikelley commented Mar 20, 2020

@PhoebeHui - Yes please. I resolved all requested changes.

@dan-shaw dan-shaw merged commit f2d5437 into microsoft:master Mar 28, 2020
@dan-shaw
Copy link
Copy Markdown
Contributor

dan-shaw commented Mar 28, 2020

@here-mikelley thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@PhoebeHui PhoebeHui

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@here-mikelley @PhoebeHui @dan-shaw