Skip to content

[cppgraphqlgen] Update to v3.2.0 and fix #10407#10446

Merged
dan-shaw merged 3 commits intomicrosoft:masterfrom
wravery:cppgraphqlgen
Mar 28, 2020
Merged

[cppgraphqlgen] Update to v3.2.0 and fix #10407#10446
dan-shaw merged 3 commits intomicrosoft:masterfrom
wravery:cppgraphqlgen

Conversation

@wravery
Copy link
Copy Markdown
Contributor

@wravery wravery commented Mar 17, 2020

Describe the pull request

  • What does your PR fix? Fixes issue #

I had a pending change to update to version 3.2.0, and I rolled in the fix for #10407 by upping the commit ID to add the source package fix.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

I've tested x64-windows with MSVC and x64-linux with gcc 7.5.0 and 8.3.0.

Yes.

@wravery
Copy link
Copy Markdown
Contributor Author

wravery commented Mar 17, 2020

Looks like the failure for vcpkg-windows-PR-test was in an unrelated port/project (libpq).

@wravery wravery changed the title Cppgraphqlgen [cppgraphqlgen] Update to v3.2.0 and fix #10407 Mar 17, 2020
@Cheney-W Cheney-W marked this pull request as ready for review March 18, 2020 02:01
@Cheney-W
Copy link
Copy Markdown
Contributor

@wravery
The CI system has some issues recently and we are fixing it.
Could you please modify the line 25 of ports/cppgraphqlgen/portfile.cmake as below:
file(INSTALL ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright)

@wravery
Copy link
Copy Markdown
Contributor Author

wravery commented Mar 18, 2020

Ok

@dan-shaw
Copy link
Copy Markdown
Contributor

/azp run

@Cheney-W Cheney-W added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Mar 20, 2020
@dan-shaw dan-shaw merged commit 409776e into microsoft:master Mar 28, 2020
@dan-shaw
Copy link
Copy Markdown
Contributor

@wravery thanks for the PR!

@wravery wravery deleted the cppgraphqlgen branch April 16, 2020 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants