Skip to content

[spirv-tools] Update to version 2020.1#10441

Merged
dan-shaw merged 6 commits intomicrosoft:masterfrom
BurningEnlightenment:dev/Enlightenment/spirv-tools
Mar 20, 2020
Merged

[spirv-tools] Update to version 2020.1#10441
dan-shaw merged 6 commits intomicrosoft:masterfrom
BurningEnlightenment:dev/Enlightenment/spirv-tools

Conversation

@BurningEnlightenment
Copy link
Copy Markdown
Contributor

I'm currently preparing a cmake integrated bgfx port (requested here #1303) which requires a newer spirv-tools version. Additionally I updated the portfile to rely on the new upstream cmake install support.
I included the spirv-headers update, because it is only directly used by spirv-tools and the new spirv-tools version is not compatible with the old spirv-headers version.

@ras0219-msft
Copy link
Copy Markdown
Contributor

/azp run

@NancyLi1013 NancyLi1013 self-assigned this Mar 18, 2020
Comment thread ports/spirv-headers/portfile.cmake
Comment thread ports/spirv-headers/portfile.cmake
Comment thread ports/spirv-headers/CONTROL
Comment thread ports/spirv-tools/portfile.cmake Outdated
@NancyLi1013
Copy link
Copy Markdown
Contributor

It seems that there is something wrong with Linux platform.
I will re run it.

@NancyLi1013
Copy link
Copy Markdown
Contributor

/azp run

@BurningEnlightenment
Copy link
Copy Markdown
Contributor Author

It seems that there is something wrong with Linux platform.

@NancyLi1013 I found the underlying issue: vcpkg_fixup_cmake_targets() uses share/${PORT} => share/spirv-tools by default. The cmake, configs, however are written to share/SPIRV-Tools by the upstream project install script.

@NancyLi1013
Copy link
Copy Markdown
Contributor

Thanks for your deepest investigation about this issue.
It looks good now.

@dan-shaw
Copy link
Copy Markdown
Contributor

/azp run

@NancyLi1013 NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Mar 20, 2020
Copy link
Copy Markdown
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dan-shaw dan-shaw merged commit 0a64f3a into microsoft:master Mar 20, 2020
@BurningEnlightenment BurningEnlightenment deleted the dev/Enlightenment/spirv-tools branch March 20, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants