Skip to content

[skia] Fix vswhere.exe can't find VS2017 with -sort#10437

Merged
dan-shaw merged 2 commits intomicrosoft:masterfrom
LilyWangL:dev/Lily/CI0317
Mar 23, 2020
Merged

[skia] Fix vswhere.exe can't find VS2017 with -sort#10437
dan-shaw merged 2 commits intomicrosoft:masterfrom
LilyWangL:dev/Lily/CI0317

Conversation

@LilyWangL
Copy link
Copy Markdown
Contributor

Fix vswhere.exe can't find VS2017 with the error as below:

ERROR at //gn/BUILDCONFIG.gn:133:29: Script returned non-zero exit code.
    win_toolchain_version = exec_script("//gn/highest_version_dir.py",
                            ^----------
Current dir: F:/0315/vcpkg/buildtrees/skia/x64-windows-dbg/
Command: F:/0315/vcpkg/downloads/tools/python/python-2.7.16-x64/python.exe F:/0315/vcpkg/buildtrees/skia/src/3c01b69efb-0a98da8354/gn/highest_version_dir.py "Visual Studio Locator version 2.5.2+gebb9f26a3d [query version 1.18.21.37008]\VC/Tools/MSVC" "[0-9]{2}\.[0-9]{2}\.[0-9]{5}"
Returned 1.

I used the command to find VS on cmd, and I got the error as below:

C:\Program Files (x86)\Microsoft Visual Studio\Installer>vswhere.exe -prerelease -legacy -products * -sort -utf8 -property installationPath
Visual Studio Locator version 2.5.2+gebb9f26a3d [query version 1.18.21.37008]
Copyright (C) Microsoft Corporation. All rights reserved.

Error 0x57: Unknown parameter: sort

I have submit an issue on the source page: microsoft/vswhere#216
No features need to test.

@dan-shaw
Copy link
Copy Markdown
Contributor

/azp run

@Cheney-W Cheney-W added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Mar 20, 2020
@dan-shaw dan-shaw merged commit 2d9a32b into microsoft:master Mar 23, 2020
Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Mar 24, 2020
[skia] Fix vswhere.exe can't find VS2017 with -sort (microsoft#10437)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants