Skip to content

[ffmpeg] Fix build static error#10368

Merged
dan-shaw merged 2 commits intomicrosoft:masterfrom
NancyLi1013:dev/NancyLi/9949-fix-ffmpeg
Mar 19, 2020
Merged

[ffmpeg] Fix build static error#10368
dan-shaw merged 2 commits intomicrosoft:masterfrom
NancyLi1013:dev/NancyLi/9949-fix-ffmpeg

Conversation

@NancyLi1013
Copy link
Contributor

@NancyLi1013 NancyLi1013 commented Mar 10, 2020

When building ffmpeg with ffmpeg or ffprobe in static, it will post the error:

There should be no bin\ directory in a static build, but D:\GitHub\vcpkg\packages\ffmpeg_x86-windows-static\bin is present.
There should be no debug\bin\ directory in a static build, but D:\GitHub\vcpkg\packages\ffmpeg_x86-windows-static\debug\bin is present.
If the creation of bin\ and/or debug\bin\ cannot be disabled, use this in the portfile to remove them

    if(VCPKG_LIBRARY_LINKAGE STREQUAL "static")
        file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/bin ${CURRENT_PACKAGES_DIR}/debug/bin)
    endif()

There should be no empty directories in D:\GitHub\vcpkg\packages\ffmpeg_x86-windows-static
The following empty directories were found:

    D:/GitHub/vcpkg/packages/ffmpeg_x86-windows-static/bin
    D:/GitHub/vcpkg/packages/ffmpeg_x86-windows-static/debug/bin

So I remove these folder to fix this issue.

Related issue #9949.

Note: All features have been passed with the following triplets:

@PhoebeHui PhoebeHui added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed waiting for response labels Mar 13, 2020
@dan-shaw dan-shaw merged commit 3d82def into microsoft:master Mar 19, 2020
@cenit
Copy link
Contributor

cenit commented Mar 20, 2020

wasn't it better to move them to tools, instead of removing them?

@cenit cenit mentioned this pull request Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants