[libpq] Fix build failure when vcpkg path contains spaces#10274
Merged
dan-shaw merged 1 commit intomicrosoft:masterfrom Mar 28, 2020
Merged
[libpq] Fix build failure when vcpkg path contains spaces#10274dan-shaw merged 1 commit intomicrosoft:masterfrom
dan-shaw merged 1 commit intomicrosoft:masterfrom
Conversation
JackBoosY
suggested changes
Mar 3, 2020
Contributor
JackBoosY
left a comment
JackBoosY
left a comment
There was a problem hiding this comment.
Could you update version info in CONTROL file?
See documentation.
Add quotes to paths in command flags
Contributor
Author
|
@JackBoosY Done |
JackBoosY
approved these changes
Mar 5, 2020
Contributor
|
/azp run |
JackBoosY
added
the
info:needs-maintainer-attention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes libpq not building when vcpkg is installed in a path with spaces (due to unquoted paths).
Not sure a port version bump is necessary since this doesn't change the output.