[sdl1] Fix incorrect compilation type after dynamic build#10105
Merged
strega-nil merged 2 commits intomicrosoft:masterfrom Mar 5, 2020
Merged
[sdl1] Fix incorrect compilation type after dynamic build#10105strega-nil merged 2 commits intomicrosoft:masterfrom
strega-nil merged 2 commits intomicrosoft:masterfrom
Conversation
NancyLi1013
suggested changes
Feb 18, 2020
Contributor
|
/azp run |
NancyLi1013
approved these changes
Feb 21, 2020
NancyLi1013
added
the
info:needs-maintainer-attention
Contributor
|
Looks good to me :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building dynamically,
vcxprojhas been copied into the source path, which caused skipping copyingvcxprojduring static builds and thus building the wrong link type.Related: #8281 #10082.
Note: this port doesn't contain any features.