Skip to content

[gts] Support for build with cmake in unix#10055

Merged
ras0219-msft merged 5 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/9784
Apr 27, 2020
Merged

[gts] Support for build with cmake in unix#10055
ras0219-msft merged 5 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/9784

Conversation

@JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Feb 13, 2020

The current CMakeLists.txt does not support building in UNIX, so add support.

Realted: #9784.

Note: this port doesn't contain any features.

@PhoebeHui
Copy link
Contributor

/azp run

1 similar comment
@PhoebeHui
Copy link
Contributor

/azp run

@JackBoosY JackBoosY marked this pull request as ready for review February 20, 2020 02:33
@dan-shaw dan-shaw added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed needs-further-review labels Mar 20, 2020
@dan-shaw
Copy link
Contributor

/azp run

@dan-shaw dan-shaw added waiting for response and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Mar 20, 2020
@dan-shaw
Copy link
Contributor

@JackBoosY CI fails on Linux

@JackBoosY
Copy link
Contributor Author

@dan-shaw Re-run and the test was successful.

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Mar 26, 2020
@dan-shaw
Copy link
Contributor

Should the CI baseline be updated and remove linux=fail?

@dan-shaw dan-shaw added waiting for response and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Mar 28, 2020
@JackBoosY
Copy link
Contributor Author

/azp run

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 2, 2020
@dan-shaw
Copy link
Contributor

dan-shaw commented Apr 6, 2020

/azp run

@JackBoosY
Copy link
Contributor Author

@dan-shaw Ready to merge now.

@ras0219-msft ras0219-msft merged commit 981daa4 into microsoft:master Apr 27, 2020
@JackBoosY JackBoosY deleted the dev/jack/9784 branch April 28, 2020 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants