Skip to content

[replxx] Add new port#10052

Merged
dan-shaw merged 2 commits intomicrosoft:masterfrom
kreuzerkrieg:replxx
Mar 28, 2020
Merged

[replxx] Add new port#10052
dan-shaw merged 2 commits intomicrosoft:masterfrom
kreuzerkrieg:replxx

Conversation

@kreuzerkrieg
Copy link
Copy Markdown
Contributor

  • What does your PR fix?
    replxx new port
  • Which triplets are supported/not supported?
    All except UWP
  • Have you updated the CI baseline?
    Yes
  • Does your PR follow the maintainer guide?
    Yes

@NancyLi1013
Copy link
Copy Markdown
Contributor

/azp run

@NancyLi1013
Copy link
Copy Markdown
Contributor

/azp run

1 similar comment
@kreuzerkrieg
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Commenter does not have sufficient privileges for PR 10052 in repo microsoft/vcpkg

@kreuzerkrieg
Copy link
Copy Markdown
Contributor Author

Commenter does not have sufficient privileges for PR 10052 in repo microsoft/vcpkg

:(
bad azure

@JackBoosY
Copy link
Copy Markdown
Contributor

JackBoosY commented Mar 4, 2020

@kreuzerkrieg Just because the member has permission to rerun the test only : )

@kreuzerkrieg
Copy link
Copy Markdown
Contributor Author

Just checked x86/x64 installation on Windows, completed successfully in both cases, please advise.

@NancyLi1013
Copy link
Copy Markdown
Contributor

Hi @kreuzerkrieg

The errors like this:

Performing C++ SOURCE FILE Test COMPILER_HAS_DEPRECATED_ATTR failed with the following output:
Change Dir: E:/10052/vcpkg/buildtrees/replxx/src/7827007a8c-9c9af6846f/build/CMakeFiles/CMakeTmp

Run Build Command(s):C:/Program Files (x86)/Microsoft Visual Studio/2017/Enterprise/Common7/IDE/CommonExtensions/Microsoft/CMake/Ninja/ninja.exe cmTC_df6f8 
[1/2] Building CXX object CMakeFiles\cmTC_df6f8.dir\src.cxx.obj

FAILED: CMakeFiles/cmTC_df6f8.dir/src.cxx.obj 

C:\PROGRA~2\MICROS~1\2017\ENTERP~1\VC\Tools\MSVC\1416~1.270\bin\Hostx64\x86\cl.exe  /nologo /TP   /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP  -DCOMPILER_HAS_DEPRECATED_ATTR /MDd /Zi /Ob0 /Od /RTC1 /showIncludes /FoCMakeFiles\cmTC_df6f8.dir\src.cxx.obj /FdCMakeFiles\cmTC_df6f8.dir\ /FS -c src.cxx

src.cxx(1): error C2065: '__deprecated__': undeclared identifier
src.cxx(1): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
src.cxx(1): error C2448: '__attribute__': function-style initializer appears to be a function definition
ninja: build stopped: subcommand failed.

Source file was:
__attribute__((__deprecated__)) int somefunc() { return 0; }
    int main() { return somefunc();}
Performing C++ SOURCE FILE Test COMPILER_HAS_DEPRECATED_ATTR failed with the following output:
Change Dir: E:/10052/vcpkg/buildtrees/replxx/src/7827007a8c-9c9af6846f/build/CMakeFiles/CMakeTmp

This info is from my local.
This port can build successfully on x86-windows triplet, but we still can get this error in
E:/10052/vcpkg/buildtrees/replxx/src/7827007a8c-9c9af6846f/build/CMakeFiles/CMakeError.log file.

Personally, it might be the root cause of CI regression.
Could you please help chect this on your local?

@kreuzerkrieg
Copy link
Copy Markdown
Contributor Author

Checked and it worked. I have another Win machine, will check it later, AFAIR it has older VS, like 2017, maybe it will repro there

@kreuzerkrieg
Copy link
Copy Markdown
Contributor Author

c:\vcpkg\vcpkg>vcpkg.exe install replxx
Computing installation plan...
The following packages will be built and installed:
replxx[core]:x86-windows
Starting package 1/1: replxx:x86-windows
Building package replxx[core]:x86-windows...
-- Downloading https://github.com/AmokHuginnsson/replxx/archive/45696c250ce39ab21dedeea962b94d7827007a8c.tar.gz...
-- Extracting source C:/vcpkg/vcpkg/downloads/AmokHuginnsson-replxx-45696c250ce39ab21dedeea962b94d7827007a8c.tar.gz
-- Using source at C:/vcpkg/vcpkg/buildtrees/replxx/src/7827007a8c-9c9af6846f
-- Configuring x86-windows
-- Building x86-windows-dbg
-- Building x86-windows-rel
-- Installing: C:/vcpkg/vcpkg/packages/replxx_x86-windows/share/replxx/copyright
-- Installing: C:/vcpkg/vcpkg/packages/replxx_x86-windows/share/replxx/replxxConfig.cmake
-- Performing post-build validation
-- Performing post-build validation done
Building package replxx[core]:x86-windows... done
Installing package replxx[core]:x86-windows...
Installing package replxx[core]:x86-windows... done
Elapsed time for package replxx:x86-windows: 43.71 s

Total elapsed time: 43.71 s

c:\vcpkg\vcpkg>vcpkg.exe install replxx:x64-windows
Computing installation plan...
The following packages will be built and installed:
replxx[core]:x64-windows
Starting package 1/1: replxx:x64-windows
Building package replxx[core]:x64-windows...
-- Using cached C:/vcpkg/vcpkg/downloads/AmokHuginnsson-replxx-45696c250ce39ab21dedeea962b94d7827007a8c.tar.gz
-- Using source at C:/vcpkg/vcpkg/buildtrees/replxx/src/7827007a8c-9c9af6846f
-- Configuring x64-windows
-- Building x64-windows-dbg
-- Building x64-windows-rel
-- Installing: C:/vcpkg/vcpkg/packages/replxx_x64-windows/share/replxx/copyright
-- Installing: C:/vcpkg/vcpkg/packages/replxx_x64-windows/share/replxx/replxxConfig.cmake
-- Performing post-build validation
-- Performing post-build validation done
Building package replxx[core]:x64-windows... done
Installing package replxx[core]:x64-windows...
Installing package replxx[core]:x64-windows... done
Elapsed time for package replxx:x64-windows: 34.84 s

Total elapsed time: 34.84 s

Not sure what else I can do on my side. I dont even fully understand what fails in your CI, looks like it is a CMake internal compilation of their internal cpp to check for compiler features. Looks like the MSVC miserably fails to detect a CXX feature, sounds like mismatch between MSVC and CMAKE versions. This may be related.
Sounds like Gor Nishanov needed here :)

@JackBoosY
Copy link
Copy Markdown
Contributor

JackBoosY commented Mar 10, 2020

CMake Error at C:/vsts/_work/3/s/scripts/buildsystems/vcpkg.cmake:188 (_add_executable):
  Cannot find source file:

    C:/vsts/_work/3/s/buildtrees/replxx/src/7827007a8c-9c9af6846f/build/CMakeFiles/CMakeTmp/src.cxx

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .m .M .mm .h .hh .h++ .hm
  .hpp .hxx .in .txx
Call Stack (most recent call first):
  C:/vsts/_work/3/s/buildtrees/replxx/src/7827007a8c-9c9af6846f/build/CMakeFiles/CMakeTmp/CMakeLists.txt:13 (add_executable)

@strega-nil Could you please have a look?

@kreuzerkrieg
Copy link
Copy Markdown
Contributor Author

bump

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Mar 17, 2020
@strega-nil
Copy link
Copy Markdown
Contributor

cc @dan-shaw

@dan-shaw
Copy link
Copy Markdown
Contributor

/azp run

@JackBoosY JackBoosY removed the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Mar 20, 2020
@JackBoosY
Copy link
Copy Markdown
Contributor

Please resolve windows regression, get failure log here.

@dan-shaw
Copy link
Copy Markdown
Contributor

@kreuzerkrieg We are still getting the same error as before and I'm not sure what is causing the problem. Could we set this library as failing on the baseline? If someone else has the same issue, we can fix it in another PR.

@kreuzerkrieg
Copy link
Copy Markdown
Contributor Author

done

@JackBoosY JackBoosY added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed waiting for response labels Mar 22, 2020
@dan-shaw dan-shaw merged commit d2512ed into microsoft:master Mar 28, 2020
@dan-shaw
Copy link
Copy Markdown
Contributor

@kreuzerkrieg thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants