Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[arrow] CMake config files for Dataset are not copied to the install directory #28120

Closed
piotrwendykier opened this issue Dec 2, 2022 · 0 comments · Fixed by #28122
Closed

[arrow] CMake config files for Dataset are not copied to the install directory #28120

piotrwendykier opened this issue Dec 2, 2022 · 0 comments · Fixed by #28122
Assignees
@Cheney-W
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist

Comments

@piotrwendykier
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I built Arrow 10.0.1 using:

vcpkg.exe install "arrow[core,csv,dataset,filesystem,json,parquet]" --triplet=x64-windows-static --x-install-root=%installDir% --recurse

I cannot link arrow_dataset.lib using documented CMake functions (find_package(ArrowDataset REQUIRED), target: ArrowDataset::arrow_dataset_static), because ArrowDatasetConfig.cmake and other configuration files for Dataset are not copied to the install directory.

Proposed solution

The solution was proposed here: apache/arrow#14801

Describe alternatives you've considered
Currently you can use find_library instead of find_package to configure ArrowDataset in CMake.
@piotrwendykier piotrwendykier changed the title [<arrow>] CMake config files for Dataset are not copied to the install directory [arrow] CMake config files for Dataset are not copied to the install directory Dec 2, 2022
@Cheney-W Cheney-W added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Dec 2, 2022
piotrwendykier added a commit to piotrwendykier/vcpkg that referenced this issue Dec 2, 2022
@piotrwendykier
Fix for issue microsoft#28120.
ded272a
@piotrwendykier piotrwendykier mentioned this issue Dec 2, 2022
Merged
dan-shaw pushed a commit that referenced this issue Dec 14, 2022
@piotrwendykier @FrankXie05
Fix for issue #28120. (#28122)
4b6b7f4 
* Fix for issue #28120.

* Updated port-version for arrow.

* overwrite version

Co-authored-by: FrankXie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cheney-W Cheney-W

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for issue #28120. piotrwendykier/vcpkg
2 participants
@piotrwendykier @Cheney-W