Skip to content

vcpkg integrate: Add support for zsh#87

Merged
BillyONeal merged 3 commits into
microsoft:mainfrom
autoantwort:integrate_zsh
Jul 29, 2021
Merged

vcpkg integrate: Add support for zsh#87
BillyONeal merged 3 commits into
microsoft:mainfrom
autoantwort:integrate_zsh

Conversation

@autoantwort
Copy link
Copy Markdown
Contributor

Comment thread src/vcpkg/commands.integrate.cpp Outdated
@BillyONeal
Copy link
Copy Markdown
Member

This looks good from a vcpkg view; I'm trying to get someone who understands zsh to help review https://twitter.com/MalwareMinigun/status/1415763885441765377

@ras0219-msft
Copy link
Copy Markdown
Collaborator

Since there's a lack of progress on getting additional zsh reviewers, should this be merged?

@autoantwort
Copy link
Copy Markdown
Contributor Author

autoantwort commented Jul 27, 2021

If you ask me, yes ;) I am using it on my mac with zsh and it works :)
And you already merged microsoft/vcpkg#18274

@BillyONeal BillyONeal merged commit 1986347 into microsoft:main Jul 29, 2021
@BillyONeal
Copy link
Copy Markdown
Member

¯\_(ツ)_/¯ Thanks for your contribution!

@BillyONeal BillyONeal mentioned this pull request Jul 29, 2021
@autoantwort autoantwort deleted the integrate_zsh branch September 4, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants