replacing applocal.ps1 with C++ 😍#814
Merged
ras0219-msft merged 58 commits intomicrosoft:mainfrom Dec 31, 2022
Merged
Conversation
Please enter a commit message to explain why this merge is necessary,
BillyONeal
reviewed
Dec 28, 2022
vicroms
approved these changes
Dec 28, 2022
Member
vicroms
left a comment
vicroms
left a comment
There was a problem hiding this comment.
LGTM. I'd like to have continuous tests for the "library specific" ones, but they worked when tested locally.
BillyONeal
approved these changes
Dec 29, 2022
Contributor
|
This PR hard codes informations about some plugin binaries for some ports into a binary which is maintained in another repository than the ports which provide these plugins.
|
Member
|
This is Valeria's internship project; it is intended to be phase 1 of removing our dependence on PowerShell. We intend to design and implement a generic approach after merging this PR. |
ras0219-msft
approved these changes
Dec 30, 2022
Collaborator
ras0219-msft
left a comment
ras0219-msft
left a comment
There was a problem hiding this comment.
LGTM if we add deployment of both vcpkg.exe AND applocal.ps1 into export.
Collaborator
|
Thanks Val! |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review 🙏