[vcpkg] allow --version to check the version#50
Merged
strega-nil merged 1 commit intomicrosoft:mainfrom Apr 15, 2021
Merged
Conversation
strega-nil
added
the
requires:discussion
Contributor
|
requires:discussion on best way to actually do this |
src/vcpkg/vcpkgcmdarguments.cpp
Outdated
| } | ||
| continue; | ||
| } | ||
| if (basic_arg == "--version" && args.command.empty()) |
Collaborator
There was a problem hiding this comment.
I'd suggest moving this up to the top as:
if (arg_first != arg_last && arg_first + 1 == arg_last && *arg_first == "--version") {
args.command = "version";
return args;
}With the current implementation,
vcpkg --version install blah
is interpreted as vcpkg version install blah which probably isn't correct. If nothing else, it should have the same semantics as
vcpkg install blah --version
(i.e. it should fail in the same way or succeed in the same way)
Contributor
Author
There was a problem hiding this comment.
Yeah that sounds better
autoantwort
force-pushed
the
allow---version
branch
from
e48b419 to
ea8822e
Compare
Contributor
|
Thanks @autoantwort |
strega-nil
added a commit
that referenced
this pull request
Apr 15, 2021
The following PRs are included: * hopefully fix crash in constraints (#60) * [vcpkg] allow --version to check the version (#50) * Remove baseline warning (#27) * [git] always pass autocrlf=false (#58) * ignore QtCreator CMake project files (#54) * ignore .DS_store files (#53) * [vcpkg] x-add-version now also checks if the manifest file is properly formatted (#43) * hopefully fix ci issue #16773 (#34) * Add docs to set VCPKG_ROOT to run tests (#45) * [vcpkg] x-add-version improve speed by calling get_builtin_baseline only once (#44) * add clang-format version to format-cxxcode (#41) * [vcpkg] Introduce experimental workaround X_VCPKG_NUGET_ID_PREFIX (#40) * [supports] Add `native` identifier expression and x-check-support command (#29) * [metrics] Split reporting of installs into name:triplet (#39) * [vcpkg] Improve error when accessing missing feature (#38) * [vcpkg] Allow shallow git registries (#37) * Disable git autocrlf when archiving tree (#36) * Use only named packages from extra registries (#35) * [registries] add metrics (#30) * Add vcpkg policy cmake helper port support (#17) * [osx] add support for rosetta (#23) * don't build tls12-download unless it's needed (#33) * Add new telemetry points for versioning (#21) * add cmake_minimum_required to vcpkg_tags (#25) * [x-add-versions] Perform atomic replacement of versioning files (#28) * [tools] support gsutil (#19) * add CUDA 11.1 and 11.2 to KEEP_ENV_VARS defaults (#26) * Add finite timeout on CURL metrics endpoint. (#22) * fix UB in make_error_code(utf8_errc) (#18)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if my approach is the best one.
Fixes:
:D