General object storage interface for binary caching.

[day253]

I would like to see the aws and gcs merged such that the tool exe is passed in if the intent is that they truly have the same interface so that we don't forget to update one when changes are made to the other.

This PR is to enable vcpkg users using general object storage interface for binary caching.

[day253]

#435
@BillyONeal

[day253]

Could you help me about the pipeline? I changed nearly nothing but the pipeline is failed. #457 @BillyONeal

[day253]

Could you help me about the pipeline? I changed nearly nothing but the pipeline is failed. #457 @BillyONeal

I this pull request #460 will resolve my problem.

[strega-nil-ms]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[vicroms]

Hi @day253

For PRs that include localizable strings you don't need to provide translations for each language, we have a team of translators at Microsoft that takes care of that. If you want to submit translation recommendations, please open an issue in the main vcpkg repository.

The process to add localizable strings is to:

1. declare them with DECLARE_AND_REGISTER_MESSAGE in your code
2. run the generate-message-map CMake target.

PowerShell Example:

# from the vcpkg-tool directory
mkdir build; cd build
cmake .. -G Ninja
cmake --build . --target generate-message-map

This will generate updated locales/messages.json and locales/messages.en.json that you can commit in your PR.

P.S.: We also have a useful fmt CMake target that will automatically format all code files using vcpkg's format rules.

[day253]

Hi @day253

For PRs that include localizable strings you don't need to provide translations for each language, we have a team of translators at Microsoft that takes care of that. If you want to submit translation recommendations, please open an issue in the main vcpkg repository.

The process to add localizable strings is to:

1. declare them with DECLARE_AND_REGISTER_MESSAGE in your code

2. run the generate-message-map CMake target.

PowerShell Example:

# from the vcpkg-tool directory

mkdir build; cd build

cmake .. -G Ninja

cmake --build . --target generate-message-map

This will generate updated locales/messages.json and locales/messages.en.json that you can commit in your PR.

P.S.: We also have a useful fmt CMake target that will automatically format all code files using vcpkg's format rules.

Thanks a lot. I have fixed all the review comments. Could please help me review all my changes?

[day253]

cc @coryan for the gcs changes

cc @dave-juicelabs for the aws changes

[day253]

cc @ras0219-msft as owner of binary caching

[day253]

cc @strega-nil-ms @vicroms @BillyONeal

[ras0219-msft]

I applied Victor's comment and also applied a handful of small tweaks:

• Use literals directly instead of saving them as std::string members
• Use StringLiteral/StringView over std::string
• Factor out Command{paths.get_tool(...)} as a member function.
• msgObjectStorageToolFailed is used for failures to upload OR download, so I made the message more generic

LGTM, thanks for the PR!