Skip to content

Allow shallow git registries #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ras0219-msft merged 1 commit into from
Mar 26, 2021
Merged

Allow shallow git registries #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/vcpkg/vcpkgpaths.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,8 +845,11 @@ If you wish to silence this error and use classic mode, you can:
std::error_code ec;
Files::ExclusiveFileLock guard(Files::ExclusiveFileLock::Wait::Yes, fs, lock_file, ec);

System::Command fetch_git_ref =
git_cmd_builder(*this, dot_git_dir, work_tree).string_arg("fetch").string_arg("--").string_arg(repo);
System::Command fetch_git_ref = git_cmd_builder(*this, dot_git_dir, work_tree)
.string_arg("fetch")
.string_arg("--update-shallow")
Copy link
Collaborator

@ras0219-msft ras0219-msft Mar 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.string_arg("--update-shallow")
.string_arg("--unshallow")

Since git repos reference tree objects in the history, we need the full history available.

Copy link
Contributor Author

@dg0yt dg0yt Mar 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point is: For a shallow clone such as VCPK_INSTALLATION_ROOT in Azure Pipelines, one would need to unshallow the clone at VCPKG_INSTALLATION_ROOT. You cannot apply --unshallow when fetching from the shallow clone.

Since git repos reference tree objects in the history, we need the full history available.

I'm not a git tree object expert. Anyway, do you really always need the full history, or just enough depth to resolve the references for the desired ports and versions?

.string_arg("--")
.string_arg(repo);
if (treeish.size() != 0)
{
fetch_git_ref.string_arg(treeish);
Expand Down