Closed
Conversation
This fails to build due to missing symbols. And this particular configuration of tls12-download is not needed because a binary from a MSVC build is part of the vcpkg-repository.
Contributor
|
I'd prefer to do #33. There's no need to build tls12-download anyways. |
Contributor
|
(accidentally hit close w/ comment instead of just comment) |
Contributor
Author
|
This is okay. (However, #33 does a lot of changes in one commit.) |
Contributor
Author
|
This PR is obsolete now. The merge of #33 made the tls12-download build optional and add a fix for MinGW. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In MSYS2 MinGW environments on Windows, the build of
tls12-downloadfails due to missing symbols. This change disables this component, similar to the situation on non-Windows systems. And this particular configuration of tls12-download is not needed because a binary from a MSVC build is already part of the vcpkg-repository.