Skip to content

binarycaching: implement x-aws-config,trace-ops#1864

Open
rressi-at-globus wants to merge 1 commit intomicrosoft:mainfrom
globusmedical:x-aws-trace-io-ops
Open

binarycaching: implement x-aws-config,trace-ops#1864
rressi-at-globus wants to merge 1 commit intomicrosoft:mainfrom
globusmedical:x-aws-trace-io-ops

Conversation

@rressi-at-globus
Copy link

Description

The issue

When a developer perform CMake configuration on a complex project using AWS S3 as a cache backend, vcpkg is apparently stuck for many minutes.

In reality it is just doing I/O with AWS S3 to download one by one pre-built packages.

The solution

This contribution add option x-aws-config,trace-ops to the x-aws caching backend to obtain a feedback when the tool is downloading caches from an S3 bucket.

The solution is also useful for debugging purposes and it is 100% optional.

@BillyONeal
Copy link
Member

I don't really like this mechanism; that the NuGet backend has that funny 'interactive' setting that globally applies across the entire providers expression is a mistake we should not repeat IMO.

However, I do think our console I/O for interacting with binary caches sucks and we should be telling more than we do. When I overhauled how download console I/O works one of the main priorities is "every time before we touch the network we need to tell the user we are doing that so if we get stuck they know why" but binary caching didn't get the same treatment yet.

Related:

@rressi-at-globus
Copy link
Author

I get your point and I agree with your view. Any access to the network should be traced somehow.

  • I will keep this PR open for people requiring a temporary solution (the same as us) while waiting you for a more elegant implementation of this entire module.

@BillyONeal
Copy link
Member

  • I will keep this PR open for people requiring a temporary solution (the same as us) while waiting you for a more elegant implementation of this entire module.

Just keep your additional output and remove the option to control it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants