binarycaching: implement x-aws-config,trace-ops#1864
Open
rressi-at-globus wants to merge 1 commit intomicrosoft:mainfrom
Open
binarycaching: implement x-aws-config,trace-ops#1864rressi-at-globus wants to merge 1 commit intomicrosoft:mainfrom
rressi-at-globus wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Member
|
I don't really like this mechanism; that the NuGet backend has that funny 'interactive' setting that globally applies across the entire providers expression is a mistake we should not repeat IMO. However, I do think our console I/O for interacting with binary caches sucks and we should be telling more than we do. When I overhauled how download console I/O works one of the main priorities is "every time before we touch the network we need to tell the user we are doing that so if we get stuck they know why" but binary caching didn't get the same treatment yet. Related: |
Author
|
I get your point and I agree with your view. Any access to the network should be traced somehow.
|
Member
Just keep your additional output and remove the option to control it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The issue
When a developer perform CMake configuration on a complex project using AWS S3 as a cache backend,
vcpkgis apparently stuck for many minutes.In reality it is just doing I/O with AWS S3 to download one by one pre-built packages.
The solution
This contribution add option
x-aws-config,trace-opsto thex-awscaching backend to obtain a feedback when the tool is downloading caches from an S3 bucket.The solution is also useful for debugging purposes and it is 100% optional.