Skip to content

[ABI] ABI calculation should include ports.cmake #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
strega-nil merged 2 commits into from
Feb 17, 2021
Merged

[ABI] ABI calculation should include ports.cmake #13

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
386074c
[ABI] ABI calculation should include ports.cmake
strega-nil Feb 17, 2021
5fcc6df
cache ports.cmake hash
strega-nil Feb 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/vcpkg/build.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1043,6 +1043,7 @@ namespace vcpkg::Build
}
}

abi_tag_entries.emplace_back("ports.cmake", vcpkg::Hash::get_file_hash(VCPKG_LINE_INFO, fs, paths.ports_cmake, Hash::Algorithm::Sha1));

@ras0219 ras0219 Feb 17, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this should not change during a given invocation of vcpkg, it would be great to cache it inside VcpkgPaths, similar to the existing VcpkgPaths::get_cmake_script_hashes().

abi_tag_entries.emplace_back("post_build_checks", "2");
std::vector<std::string> sorted_feature_list = action.feature_list;
Util::sort(sorted_feature_list);
Expand Down