Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should not throw in React 19 #32

Merged
merged 12 commits into from
May 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 44 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,55 @@ jobs:
- name: Setup node
uses: actions/[email protected]
with:
node-version: 16.x
node-version: 18.x
- run: npm install
- run: npm run format:check
- run: npm run type-check
- run: npm run test:ci
- run: npm run build
- name: "Check for unstaged changes"
run: |
git status --porcelain
git diff-index --quiet HEAD -- || exit 1

compat-modern:
strategy:
matrix:
# rc tag should be react 19 release candidate
react: [18, rc]
ling1726 marked this conversation as resolved.
Show resolved Hide resolved
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
name: Checkout [main]
with:
fetch-depth: 0
- name: Setup node
uses: actions/[email protected]
with:
node-version: 18.x
- run: npm install
- run: npm install react@${{matrix.react}} react-dom@${{matrix.react}} --force
- run: npm run test:ci
ling1726 marked this conversation as resolved.
Show resolved Hide resolved
env:
REACT_VERSION: ${{matrix.react}}
- run: npm run build

compat-legacy:
strategy:
matrix:
react: [16, 17]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
name: Checkout [main]
with:
fetch-depth: 0
- name: Setup node
uses: actions/[email protected]
with:
node-version: 18.x
- run: npm install
- run: npm install react@${{matrix.react}} react-dom@${{matrix.react}} @testing-library/react-hooks --force
- run: npm run test:ci -- --config ./vitest.16.17.config.ts
env:
REACT_VERSION: ${{matrix.react}}
- run: npm run build
Loading
Loading