fix: generate parameterized accessor for subclients with subclient-specific parameters by Copilot · Pull Request #9919 · microsoft/typespec

Copilot · 2026-03-04T19:56:01Z

Fix ClientProvider.cs: HasAccessorOnlyParameters() detects subclient-specific params; BuildFields() skips caching field; BuildMethods() generates parameterized accessor
Add unit tests for Parent-only subclients with accessor-only parameters
Add MetricsClientParams to SampleService/main.tsp; regenerate Sample-TypeSpec
Revert Spector azure test project changes
Run prettier on SampleService/main.tsp
Run Generate.ps1 and check in regenerated files

Original prompt

This section details on the original issue you should resolve

<issue_title>Subclient parameters need to be included in accessors</issue_title>
<issue_description>For subclients that can be created individually or from the parent, the subclient parameters are not included in the subclient accessors currently. </issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes Subclient parameters need to be included in accessors #9775

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>

packages/http-client-js/src/components/client.tsx

pkg-pr-new · 2026-03-04T20:43:19Z

Open in StackBlitz

npm i https://pkg.pr.new/@typespec/http-client-csharp@9919

commit: ca820f4

…hods Reverts incorrect JS emitter changes and implements the fix in the C# emitter (ClientProvider.cs) where the issue actually belongs. When a subclient has parameters not present on the parent client, the parent's accessor method now accepts those extra parameters and passes them to the subclient constructor. Caching is bypassed for parameterized accessors since different parameter values may produce different client instances. Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>

Copilot · 2026-03-04T20:59:45Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

aka.ms
- Triggering command: /usr/bin/curl curl -L REDACTED -o /tmp/install-dotnet.sh act-api |accessor\|Accessor de/node/bin/bash (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

packages/http-client-js/CHANGELOG.md

.chronus/changes/http-client-csharp-subclient-accessor-params-2026-03-04-20-30-00.md

Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>

...nt-csharp/generator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/ClientProvider.cs

Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>

Copilot · 2026-03-04T23:36:54Z

@copilot run prettier on the tsp file being changed

Done in dd06669 — prettier collapsed the multi-line params into a single line.

JoshLove-msft · 2026-03-05T00:48:10Z

@copilot run Generate.ps1 and check in the changes

Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>

Copilot · 2026-03-05T00:54:34Z

@copilot run Generate.ps1 and check in the changes

Done in cb0f232 — ran Generate.ps1 -filter "Sample-TypeSpec" and committed the 3 regenerated files (SampleTypeSpecClient.cs, Metrics.cs, Metrics.RestClient.cs). All 243 ClientProvider unit tests pass.

docs/samples/client/csharp/SampleService/SampleClient/src/Generated/SampleTypeSpecClient.cs

Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>

...nt-csharp/generator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/ClientProvider.cs

…ection per TCGC behavior Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>

docs/samples/client/csharp/SampleService/main.tsp

Restores the MetricsClientParams model and @clientInitialization parameters on the Metrics interface. Regenerated all generated libraries to validate the parameterized accessor behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

docs/samples/client/csharp/SampleService/SampleClient/src/Generated/SampleTypeSpecClient.cs

github-actions · 2026-03-06T03:09:34Z

No changes needing a change description found.

...nt-csharp/generator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/ClientProvider.cs

…eneration Remove redundant IsApiVersion/IsEndpoint filters in accessor loop (already handled by earlier branches). Use _inputClient.Parameters instead of _allClientParameters for parent comparison. Retain parent comparison for correctness in MultiServiceClient scenarios where params are shared. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Initial plan

1389cb6

Copilot AI assigned Copilot and JoshLove-msft Mar 4, 2026

Copilot started work on behalf of JoshLove-msft March 4, 2026 19:56 View session

fix(http-client-js): include subclient parameters in accessor methods

624a489

Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>

microsoft-github-policy-service bot added the emitter:client:js Issue for the JS client emitter: @typespec/http-client-js label Mar 4, 2026

JoshLove-msft reviewed Mar 4, 2026

View reviewed changes

packages/http-client-js/src/components/client.tsx Outdated Show resolved Hide resolved

Copilot stopped work on behalf of JoshLove-msft due to an error March 4, 2026 20:36
Failed to get response from the AI model; retried n times (total retry wait time: <duration>) Last error: Unknown error

Copilot started work on behalf of JoshLove-msft March 4, 2026 20:36 View session

microsoft-github-policy-service bot added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Mar 4, 2026

Copilot AI changed the title ~~[WIP] Add subclient parameters to accessors~~ Add subclient parameters to accessors in the C# emitter Mar 4, 2026

Copilot finished work on behalf of JoshLove-msft March 4, 2026 20:59

JoshLove-msft reviewed Mar 4, 2026

View reviewed changes

packages/http-client-js/CHANGELOG.md Show resolved Hide resolved

Copilot started work on behalf of JoshLove-msft March 4, 2026 21:50 View session

JoshLove-msft reviewed Mar 4, 2026

View reviewed changes

.chronus/changes/http-client-csharp-subclient-accessor-params-2026-03-04-20-30-00.md Outdated Show resolved Hide resolved

revert: restore http-client-js/CHANGELOG.md to original state

8c982c7

Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>

Copilot finished work on behalf of JoshLove-msft March 4, 2026 21:52

Copilot started work on behalf of JoshLove-msft March 4, 2026 21:52 View session

chore: delete stale http-client-csharp changeset file

08eb7b2

Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>

JoshLove-msft reviewed Mar 4, 2026

View reviewed changes

...nt-csharp/generator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/ClientProvider.cs Show resolved Hide resolved

Copilot finished work on behalf of JoshLove-msft March 4, 2026 21:53

Copilot started work on behalf of JoshLove-msft March 4, 2026 21:53 View session

Copilot finished work on behalf of JoshLove-msft March 4, 2026 22:06

JoshLove-msft marked this pull request as ready for review March 4, 2026 22:14

JoshLove-msft requested review from christothes, jorgerangel-msft and m-nash as code owners March 4, 2026 22:14

style: run prettier on SampleService/main.tsp

dd06669

Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>

Copilot finished work on behalf of JoshLove-msft March 4, 2026 23:37

jorgerangel-msft approved these changes Mar 4, 2026

View reviewed changes

Copilot started work on behalf of JoshLove-msft March 5, 2026 00:48 View session

chore: regenerate Sample-TypeSpec after Generate.ps1

cb0f232

Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>

Copilot finished work on behalf of JoshLove-msft March 5, 2026 00:55

JoshLove-msft enabled auto-merge March 5, 2026 02:23

JoshLove-msft disabled auto-merge March 5, 2026 02:24

JoshLove-msft reviewed Mar 5, 2026

View reviewed changes

docs/samples/client/csharp/SampleService/SampleClient/src/Generated/SampleTypeSpecClient.cs Show resolved Hide resolved

Copilot started work on behalf of JoshLove-msft March 5, 2026 02:26 View session

Changes before error encountered

5166912

Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>

JoshLove-msft reviewed Mar 5, 2026

View reviewed changes

...nt-csharp/generator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/ClientProvider.cs Outdated Show resolved Hide resolved

JoshLove-msft reviewed Mar 5, 2026

View reviewed changes

...nt-csharp/generator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/ClientProvider.cs Outdated Show resolved Hide resolved

refactor: simplify subclient accessor params - remove propagation det…

8d161f2

…ection per TCGC behavior Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>

JoshLove-msft reviewed Mar 5, 2026

View reviewed changes

docs/samples/client/csharp/SampleService/main.tsp Show resolved Hide resolved

JoshLove-msft reviewed Mar 6, 2026

View reviewed changes

docs/samples/client/csharp/SampleService/SampleClient/src/Generated/SampleTypeSpecClient.cs Show resolved Hide resolved

JoshLove-msft enabled auto-merge March 6, 2026 03:30

JoshLove-msft reviewed Mar 6, 2026

View reviewed changes

...nt-csharp/generator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/ClientProvider.cs Outdated Show resolved Hide resolved

jorgerangel-msft approved these changes Mar 6, 2026

View reviewed changes

JoshLove-msft added this pull request to the merge queue Mar 6, 2026

Merged via the queue into main with commit 537c5d5 Mar 6, 2026
33 checks passed

JoshLove-msft deleted the copilot/add-subclient-parameters-accessors branch March 6, 2026 16:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: generate parameterized accessor for subclients with subclient-specific parameters#9919

fix: generate parameterized accessor for subclients with subclient-specific parameters#9919
JoshLove-msft merged 13 commits intomainfrom
copilot/add-subclient-parameters-accessors

Copilot AI commented Mar 4, 2026 •

edited

Loading

Uh oh!

Uh oh!

pkg-pr-new bot commented Mar 4, 2026 •

edited

Loading

Uh oh!

Copilot AI commented Mar 4, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Mar 4, 2026

Uh oh!

JoshLove-msft commented Mar 5, 2026

Uh oh!

Copilot AI commented Mar 5, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 6, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comments on the Issue (you are @copilot in this section)

Uh oh!

Uh oh!

pkg-pr-new bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI commented Mar 4, 2026

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Mar 4, 2026

Uh oh!

JoshLove-msft commented Mar 5, 2026

Uh oh!

Copilot AI commented Mar 5, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 6, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Mar 4, 2026 •

edited

Loading

pkg-pr-new bot commented Mar 4, 2026 •

edited

Loading