Skip to content

Fix optional Content-Type header detection by unifying parameter processing #9528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoshLove-msft merged 4 commits into from
Jan 30, 2026
Merged

Fix optional Content-Type header detection by unifying parameter processing #9528

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b651fd0
Initial plan
Copilot Jan 30, 2026
b24a9cc
Fix optional contentType issue by passing header parameter to fromSdk…
Copilot Jan 30, 2026
342e177
Unify parameter processing to always pass property to fromSdkType
Copilot Jan 30, 2026
43ba7df
Fix formatting in operation-converter.ts
Copilot Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions packages/http-client-csharp/emitter/src/lib/operation-converter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,11 @@ function updateMethodParameter(
if (methodParameter.location === RequestLocation.Body) {
// Convert constants to enums
if (methodParameter.type.kind === "constant") {
methodParameter.type = fromSdkType(sdkContext, operationHttpParameter.type);
methodParameter.type = fromSdkType(
sdkContext,
operationHttpParameter.type,
operationHttpParameter,
);
}
}
}
Expand Down Expand Up @@ -419,7 +423,7 @@ function fromQueryParameter(
p: SdkQueryParameter,
rootApiVersions: string[],
): InputQueryParameter {
const parameterType = fromSdkType(sdkContext, p.type);
const parameterType = fromSdkType(sdkContext, p.type, p);

const retVar: InputQueryParameter = {
kind: "query",
Expand Down Expand Up @@ -448,7 +452,7 @@ function fromPathParameter(
p: SdkPathParameter,
rootApiVersions: string[],
): InputPathParameter {
const parameterType = fromSdkType(sdkContext, p.type);
const parameterType = fromSdkType(sdkContext, p.type, p);

const retVar: InputPathParameter = {
kind: "path",
Expand Down Expand Up @@ -479,7 +483,7 @@ function fromHeaderParameter(
p: SdkHeaderParameter,
rootApiVersions: string[],
): InputHeaderParameter {
const parameterType = fromSdkType(sdkContext, p.type);
const parameterType = fromSdkType(sdkContext, p.type, p);

const retVar: InputHeaderParameter = {
kind: "header",
Expand Down Expand Up @@ -509,7 +513,7 @@ function fromBodyParameter(
p: SdkBodyParameter,
rootApiVersions: string[],
): InputBodyParameter {
const parameterType = fromSdkType(sdkContext, p.type);
const parameterType = fromSdkType(sdkContext, p.type, p);

const retVar: InputBodyParameter = {
kind: "body",
Expand Down