-
Notifications
You must be signed in to change notification settings - Fork 375
Support 3xx redirect status codes in http-client-csharp generator #9498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a4b175e
Initial plan
Copilot 897f92d
Add support for 3xx status codes (including 302 redirect)
Copilot e9fac6a
Add unit test for 302 redirect status code support
Copilot 939090e
Clarify 302 redirect documentation based on code review
Copilot 5064523
Remove TestProjects files as requested
Copilot 308cfa2
Remove http-specs redirect directory as requested
Copilot 16228c0
Add test for CreateRequest method to verify classifier usage
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
...tp-client-csharp/generator/TestProjects/Spector/http/response/redirect/Configuration.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
|
JoshLove-msft marked this conversation as resolved.
Outdated
|
||
| "output-folder": ".", | ||
| "namespace": "Response.Redirect", | ||
| "library-name": "Response.Redirect" | ||
| } | ||
1 change: 1 addition & 0 deletions
1
...ttp-client-csharp/generator/TestProjects/Spector/http/response/redirect/tsp-location.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| directory: ../../../../../../../http-specs/specs/response/redirect |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import "@typespec/http"; | ||
|
JoshLove-msft marked this conversation as resolved.
Outdated
|
||
| import "@typespec/spector"; | ||
|
|
||
| using Http; | ||
| using Spector; | ||
|
|
||
| /** | ||
| * Test for HTTP redirect status codes. | ||
| */ | ||
| @scenarioService("/response/redirect") | ||
| namespace Response.Redirect; | ||
|
|
||
| @scenario | ||
| @scenarioDoc(""" | ||
| Test case for 302 redirect response. | ||
|
|
||
| Verify that the client can receive and process a 302 redirect response with a Location header. | ||
| This is commonly used in OAuth-style authorization flows where the service provides a redirect | ||
| URI that the application can use to navigate users to the mobile operator's network for authentication. | ||
|
|
||
| Expected status code 302 and response headers: | ||
| - Location: /redirected | ||
| """) | ||
| @route("/302") | ||
| @get | ||
| op redirect302(): { | ||
| @statusCode | ||
| _: 302; | ||
|
|
||
| @header | ||
| location: url; | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import { passOnSuccess, ScenarioMockApi, MockApiDefinition } from "@typespec/spec-api"; | ||
|
|
||
| export const Scenarios: Record<string, ScenarioMockApi> = {}; | ||
|
|
||
| const validRedirect302: MockApiDefinition = { | ||
| uri: "/response/redirect/302", | ||
| method: "get", | ||
| request: {}, | ||
| response: { | ||
| status: 302, | ||
| headers: { | ||
| location: "/redirected", | ||
| }, | ||
| }, | ||
| kind: "MockApiDefinition", | ||
| }; | ||
|
|
||
| Scenarios.Response_Redirect_redirect302 = passOnSuccess(validRedirect302); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.