-
Notifications
You must be signed in to change notification settings - Fork 325
Add security warning to tsp init documentation and CLI for external templates #8917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: markcowl <[email protected]>
Co-authored-by: markcowl <[email protected]>
|
No changes needing a change description found. |
|
@copilot please add and appropriate bug fix changes entry for the changelog, mentioning the issue number that this PR resolves and referencing the impacted package. |
|
@copilot also add this warning in the js comment documentation for the 'tsp init` command parameter 'templateUrl' |
Co-authored-by: markcowl <[email protected]>
|
@copilot the changelog entry should be for the change to compiler command line documentation, no changelog is needed for website changes. Please remove that changelog. Also add the warning text in the description for the 'tsp init` command parameter 'templateUrl', which is here: https://github.com/microsoft/typespec/blob/main/packages/compiler/src/core/cli/cli.ts#L213-L215 and create a changelog entry for this change. |
Co-authored-by: markcowl <[email protected]>
Added security warning to the templatesUrl parameter description in the CLI code (packages/compiler/src/core/cli/cli.ts). The warning now appears in the |
Co-authored-by: markcowl <[email protected]>
Updated changelog to only include @typespec/compiler package (removed @typespec/website) in commit c51a670. The warning text was already added to the templatesUrl parameter description in commit 0c82d0f. |
commit: |
|
/azp run typespec - PR Tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
You can try these changes here
|
Add warning to documentation and CLI help for templateUrl parameter in tsp init command
Completed:
templateUrlparameter in tsp init command #8916Changes Made:
Added security warnings to both the CLI handbook and scaffolding templates documentation
Added security warning to the templatesUrl parameter description in the CLI code, which appears in the
tsp init --helpoutputThe warnings inform users that downloading or using an untrusted template may contain malicious packages that can compromise their system and data, matching the warning prompt shown in the
tsp initcommandWarning text is consistent across documentation files and CLI help
Added changelog entry using chronus format for @typespec/compiler package only (no changelog needed for website documentation changes)
Fixes Add warning text to documentation on
templateUrlparameter in tsp init command #8916Original prompt
templateUrlparameter in tsp init command #8916✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.