Reserve keywords - #6416
Merged
Timothee Guerin (timotheeguerin) merged 12 commits intoMar 13, 2025
Merged
Conversation
Collaborator
|
All changed packages have been documented.
Show changes
|
Collaborator
|
You can try these changes here
|
Timothee Guerin (timotheeguerin)
requested a review
from Rodge Fu (RodgeFu)
as a code owner
March 13, 2025 20:28
Christopher Radek (chrisradek)
approved these changes
Mar 13, 2025
Christopher Radek (chrisradek)
left a comment
Member
There was a problem hiding this comment.
Looks great!
Christopher Radek (chrisradek)
approved these changes
Mar 13, 2025
Christopher Radek (chrisradek)
left a comment
Member
There was a problem hiding this comment.
Looks great!
Dmitrii Sedelnikov (dmnorc)
pushed a commit
to dmnorc/typespec
that referenced
this pull request
Apr 9, 2025
fix microsoft#6096 Reserve all the keywords we discussed: ## Changes from the design approved: - added `self` which might be a better alternative to `this` - dropped `base` and replaced with `super`. `base` was a common name used in our operation test `op foo is base` so feels it might be as well outside. ## Behavior Errors if used in those cases: - declaration name - referenced directly as a type reference - referenced as the base reference in a member expression Ok if used in those: - model property name - enum member name - union variant name - decorator call expression even if its just `@statemachine` (differ from the disallowed `statemachine` reference above)
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #6096
Reserve all the keywords we discussed:
Changes from the design approved:
selfwhich might be a better alternative tothisbaseand replaced withsuper.basewas a common name used in our operation testop foo is baseso feels it might be as well outside.Behavior
Errors if used in those cases:
Ok if used in those:
@statemachine(differ from the disallowedstatemachinereference above)