Migrate `@service` and `@info` to use `valueof` for the option bag by timotheeguerin · Pull Request #6108 · microsoft/typespec

timotheeguerin · 2025-02-21T17:14:33Z

azure-sdk · 2025-02-21T17:19:02Z

All changed packages have been documented.

✅ @typespec/compiler
✅ @typespec/http-server-csharp
✅ @typespec/http-specs
✅ @typespec/http
✅ @typespec/openapi
✅ @typespec/openapi3
✅ @typespec/rest
✅ @typespec/versioning

Show changes

`@typespec/compiler` - feature ✏️

Migrate @service decorator options to take in a value,> ,> diff lang="tsp",> -@service({title: "My service"}),> +@service(#{title: "My service"}),>

`@typespec/openapi` - feature ✏️

Migrate @info decorator to expect a value,> ,> diff lang="tsp",> -@info({ version: "1.0.0" }),> +@info(#{ version: "1.0.0" }),> ,> ,> diff lang="tsp",> -@info({,> +@info(#{,> termsOfService: "http://example.com/terms/",,> - contact: {,> + contact: #{,> name: "API Support",,> url: "http://www.example.com/support",,> email: "support@example.com",> },,> }),>

`@typespec/http-server-csharp` - internal ✏️

Update tests and samples

`@typespec/http-specs` - internal ✏️

Update tests and samples

`@typespec/http` - internal ✏️

Update tests and samples

`@typespec/openapi3` - internal ✏️

Update tests and samples

`@typespec/rest` - internal ✏️

Update tests and samples

`@typespec/versioning` - internal ✏️

Update tests and samples

packages/http-client-csharp/emitter/test/Unit/input-parameter.test.ts

azure-sdk · 2025-02-21T18:14:06Z

You can try these changes here

🛝 Playground	🌐 Website	🛝 VSCode Extension

packages/openapi3/test/tsp-openapi3/output/petstore-swagger/main.tsp

timotheeguerin · 2025-02-21T19:45:51Z

/azp run

azure-pipelines · 2025-02-21T19:46:31Z

Azure Pipelines successfully started running 2 pipeline(s).

timotheeguerin · 2025-02-21T21:33:29Z

/azp run

azure-pipelines · 2025-02-21T21:34:07Z

Azure Pipelines successfully started running 2 pipeline(s).

…rate/valueof-remaining

Uptake change from microsoft/typespec#6108

…icrosoft#6108) fix microsoft#5934

@service

The example code no longer compiles because the @service decorator expects an #object value parameter in post-1.0 typespec code. Relevant upstream PR: * microsoft/typespec#6108 The updated code has been tested with the latest typespec 1.6 compiler and language server.

timotheeguerin added 3 commits February 21, 2025 09:01

Migrate @service and @info to use valueof for object values

3c8ee7c

progress

c4745d6

fix

7493385

timotheeguerin added 2 commits February 21, 2025 09:20

regen docs

ad6d7cd

more fixes

7205593

timotheeguerin commented Feb 21, 2025

View reviewed changes

packages/http-client-csharp/emitter/test/Unit/input-parameter.test.ts Show resolved Hide resolved

timotheeguerin and others added 7 commits February 21, 2025 09:26

fixes

ca701a1

fix

e82df9f

Create migrate-valueof-remaining-2025-1-21-17-35-12.md

09a253c

.

3621b4c

.

e2a6693

Create migrate-valueof-remaining-2025-1-21-17-48-47.md

dcaf4f6

Create migrate-valueof-remaining-2025-1-21-17-57-6.md

025560a

timotheeguerin marked this pull request as ready for review February 21, 2025 18:11

timotheeguerin requested review from AlitzelMendez, allenjzhang, bterlson, chrisradek, markcowl and witemple-msft as code owners February 21, 2025 18:11

chrisradek reviewed Feb 21, 2025

View reviewed changes

packages/openapi3/test/tsp-openapi3/output/petstore-swagger/main.tsp Outdated Show resolved Hide resolved

timotheeguerin mentioned this pull request Feb 21, 2025

Migrate @service and @info to use values Azure/typespec-azure#2247

Merged

fix

47a6bc5

chrisradek approved these changes Feb 21, 2025

View reviewed changes

timotheeguerin added 7 commits February 21, 2025 13:56

.

89170bd

regen

4591019

fix test

c981ffa

fix openapi3

827c62f

Merge branch 'main' of https://github.com/Microsoft/typespec into mig…

01686f3

…rate/valueof-remaining

regen

0d25346

fix

5ba6947

timotheeguerin added this pull request to the merge queue Feb 28, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 28, 2025

timotheeguerin added 2 commits February 28, 2025 10:43

Merge branch 'main' into migrate/valueof-remaining

52d4f4d

format

b4c5f3a

timotheeguerin enabled auto-merge February 28, 2025 18:48

timotheeguerin mentioned this pull request Feb 28, 2025

Migrate specs @service and @info to use value object Azure/azure-rest-api-specs#32916

Merged

fix new test

e42f457

timotheeguerin added this pull request to the merge queue Feb 28, 2025

Merged via the queue into microsoft:main with commit 3fe2d61 Feb 28, 2025
24 checks passed

timotheeguerin deleted the migrate/valueof-remaining branch February 28, 2025 20:03

github-merge-queue bot pushed a commit to Azure/typespec-azure that referenced this pull request Mar 1, 2025

Migrate @service and @info to use values (#2247)

a4c6f10

Uptake change from microsoft/typespec#6108

dmnorc pushed a commit to dmnorc/typespec that referenced this pull request Apr 9, 2025

Migrate @service and @info to use valueof for the option bag (m…

fec43d5

…icrosoft#6108) fix microsoft#5934

jbethune mentioned this pull request Nov 16, 2025

Use object value syntax for @service parameter mario-guerra/typespec101-files#1

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate `@service` and `@info` to use `valueof` for the option bag#6108

Migrate `@service` and `@info` to use `valueof` for the option bag#6108
timotheeguerin merged 23 commits intomicrosoft:mainfrom
timotheeguerin:migrate/valueof-remaining

timotheeguerin commented Feb 21, 2025 •

edited

Loading

Uh oh!

azure-sdk commented Feb 21, 2025 •

edited

Loading

`@typespec/compiler` - feature ✏️

`@typespec/openapi` - feature ✏️

`@typespec/http-server-csharp` - internal ✏️

`@typespec/http-specs` - internal ✏️

`@typespec/http` - internal ✏️

`@typespec/openapi3` - internal ✏️

`@typespec/rest` - internal ✏️

`@typespec/versioning` - internal ✏️

Uh oh!

Uh oh!

azure-sdk commented Feb 21, 2025 •

edited

Loading

Uh oh!

Uh oh!

timotheeguerin commented Feb 21, 2025

Uh oh!

azure-pipelines bot commented Feb 21, 2025

Uh oh!

timotheeguerin commented Feb 21, 2025

Uh oh!

azure-pipelines bot commented Feb 21, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

timotheeguerin commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-sdk commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

@typespec/compiler - feature ✏️

@typespec/openapi - feature ✏️

@typespec/http-server-csharp - internal ✏️

@typespec/http-specs - internal ✏️

@typespec/http - internal ✏️

@typespec/openapi3 - internal ✏️

@typespec/rest - internal ✏️

@typespec/versioning - internal ✏️

Uh oh!

Uh oh!

azure-sdk commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

timotheeguerin commented Feb 21, 2025

Uh oh!

azure-pipelines bot commented Feb 21, 2025

Uh oh!

timotheeguerin commented Feb 21, 2025

Uh oh!

azure-pipelines bot commented Feb 21, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

timotheeguerin commented Feb 21, 2025 •

edited

Loading

azure-sdk commented Feb 21, 2025 •

edited

Loading

`@typespec/compiler` - feature ✏️

`@typespec/openapi` - feature ✏️

`@typespec/http-server-csharp` - internal ✏️

`@typespec/http-specs` - internal ✏️

`@typespec/http` - internal ✏️

`@typespec/openapi3` - internal ✏️

`@typespec/rest` - internal ✏️

`@typespec/versioning` - internal ✏️

azure-sdk commented Feb 21, 2025 •

edited

Loading