Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java generator, fix generator-test when running from main #4334

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

XiaofeiCao
Copy link
Member

@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:java Issue for the Java client emitter: @typespec/http-client-java label Sep 4, 2024
@azure-sdk
Copy link
Collaborator

No changes needing a change description found.

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

Copy link
Contributor

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as it is dev-only fallback when the Main.java runs without tspconfig input.

@XiaofeiCao XiaofeiCao added this pull request to the merge queue Sep 5, 2024
Merged via the queue into main with commit 93377fd Sep 5, 2024
25 checks passed
@XiaofeiCao XiaofeiCao deleted the java_fix_generator_test branch September 5, 2024 02:19
sarangan12 pushed a commit to sarangan12/typespec that referenced this pull request Sep 16, 2024
…4334)

- Part of microsoft#4315, though before
TypeSpec ARM fix, we'll probably will not merge that PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter:client:java Issue for the Java client emitter: @typespec/http-client-java
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants