Add support for encoding numeric types as string #4020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheeguerin
requested review from
bterlson,
markcowl and
allenjzhang
as code owners
|
All changed packages have been documented.
|
|
You can try these changes here
|
markcowl
approved these changes
Jul 30, 2024
MaryGao
reviewed
Jul 31, 2024
| @@ -134,3 +134,41 @@ model User { | |||
| </td> | |||
| </tr> | |||
| </table> | |||
|
|
|||
| ## Numeric types ( `int64`, `decimal128`, `float64`, etc.) | |||
There was a problem hiding this comment.
Do we have a plan to add linter rule to warn that some safe numeric is marked as encode string e.g int16, or safeint?
There was a problem hiding this comment.
good point filed na issue for an azure linter Azure/typespec-azure#1277
This was referenced Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3856