-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ToSerial and ToEnum to SerializationProviders #3795
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
Issue for the C# client emitter: @typespec/http-client-csharp
label
Jul 9, 2024
API change check APIView has identified API level changes in this PR and created following API reviews. Microsoft.Generator.CSharp |
nisha-bhatia
changed the title
Draft PR unraveling - Do not merge
Move ToSerial and ToEnum to SerializationProviders
Jul 25, 2024
...rator/Microsoft.Generator.CSharp.ClientModel/src/Providers/FixedEnumSerializationProvider.cs
Outdated
Show resolved
Hide resolved
...rator/Microsoft.Generator.CSharp.ClientModel/src/Providers/FixedEnumSerializationProvider.cs
Outdated
Show resolved
Hide resolved
...rator/Microsoft.Generator.CSharp.ClientModel/src/Providers/FixedEnumSerializationProvider.cs
Outdated
Show resolved
Hide resolved
...rator/Microsoft.Generator.CSharp.ClientModel/src/Providers/FixedEnumSerializationProvider.cs
Outdated
Show resolved
Hide resolved
...rator/Microsoft.Generator.CSharp.ClientModel/src/Providers/FixedEnumSerializationProvider.cs
Outdated
Show resolved
Hide resolved
...es/http-client-csharp/generator/Microsoft.Generator.CSharp.ClientModel/src/ScmTypeFactory.cs
Show resolved
Hide resolved
packages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/Providers/TypeProvider.cs
Show resolved
Hide resolved
packages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/Snippets/Snippet.New.cs
Outdated
Show resolved
Hide resolved
chunyu3
reviewed
Jul 26, 2024
.../Microsoft.Generator.CSharp.ClientModel/src/Providers/ExtensibleEnumSerializationProvider.cs
Outdated
Show resolved
Hide resolved
.../Microsoft.Generator.CSharp.ClientModel/src/Providers/ExtensibleEnumSerializationProvider.cs
Outdated
Show resolved
Hide resolved
.../Microsoft.Generator.CSharp.ClientModel/src/Providers/ExtensibleEnumSerializationProvider.cs
Outdated
Show resolved
Hide resolved
…rp.ClientModel/src/Providers/ExtensibleEnumSerializationProvider.cs Co-authored-by: JoshLove-msft <[email protected]>
…rp.ClientModel/src/Providers/ExtensibleEnumSerializationProvider.cs Co-authored-by: JoshLove-msft <[email protected]>
m-nash
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3651