Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ToSerial and ToEnum to SerializationProviders #3795

Merged
merged 41 commits into from
Jul 30, 2024

Conversation

nisha-bhatia
Copy link
Contributor

@nisha-bhatia nisha-bhatia commented Jul 9, 2024

Fixes: #3651

@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Jul 9, 2024
@nisha-bhatia nisha-bhatia changed the title [DRAFT] Draft PR unraveling - Do not merge Jul 9, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jul 10, 2024

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Generator.CSharp
Microsoft.Generator.CSharp.ClientModel

@nisha-bhatia nisha-bhatia self-assigned this Jul 25, 2024
@nisha-bhatia nisha-bhatia changed the title Draft PR unraveling - Do not merge Move ToSerial and ToEnum to SerializationProviders Jul 25, 2024
m-nash and others added 3 commits July 30, 2024 15:39
…rp.ClientModel/src/Providers/ExtensibleEnumSerializationProvider.cs

Co-authored-by: JoshLove-msft <[email protected]>
…rp.ClientModel/src/Providers/ExtensibleEnumSerializationProvider.cs

Co-authored-by: JoshLove-msft <[email protected]>
@m-nash m-nash enabled auto-merge July 30, 2024 22:47
@m-nash m-nash added this pull request to the merge queue Jul 30, 2024
Merged via the queue into microsoft:main with commit 1d43455 Jul 30, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move ToSerial and ToEnum to SerializationProviders from EnumProvider class
6 participants