Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upload of playground package bundle #3790

Merged

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Jul 9, 2024

A recent break in storage blob SDK corrupted the uploading of certain files Azure/azure-sdk-for-js#30138 when using the upload(text, length) method. Switching to converting to a buffer and uploading fixes the issue.

@timotheeguerin timotheeguerin changed the title Fix upload of files Fix upload of playground package bundle Jul 9, 2024
@azure-sdk
Copy link
Collaborator

No changes needing a change description found.

@azure-sdk
Copy link
Collaborator

You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/3790/

Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/3790/

@timotheeguerin timotheeguerin added this pull request to the merge queue Jul 9, 2024
Merged via the queue into microsoft:main with commit b2c03c5 Jul 9, 2024
22 checks passed
@timotheeguerin timotheeguerin deleted the fix/bundle-corruption-upload branch July 9, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants