fix the nullable value type #3567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArcturusZhang
added
the
emitter:client:csharp
|
API change check API changes are not detected in this pull request. |
ArcturusZhang
added a commit
to ArcturusZhang/autorest.csharp
that referenced
this pull request
Jun 12, 2024
6 tasks
m-nash
approved these changes
Jun 12, 2024
ArcturusZhang
added a commit
to Azure/autorest.csharp
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Azure/autorest.csharp#4678
We are only checking if the input type is a generic type, and then get its generic argument if it is.
We are not checking if it is this special generic type
System.Nullable<T>which appears to be a generic type but we actually want it to be non-generic but nullable.This PR changes the final constructor that would be invoke for all cases that a ctor of CSharpType from a
System.Typeto add a check if it isSystem.Nullable<T>, we will useTas_type, and the arguments ofTas the real arguments.