Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate docs in hover or completion details #2976

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Fix duplicate docs in hover or completion details #2976

merged 3 commits into from
Mar 1, 2024

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Mar 1, 2024 •
edited
Loading

Before
image

Now
image

@azure-sdk
Copy link
Collaborator

azure-sdk commented Mar 1, 2024 •
edited
Loading

All changed packages have been documented.

bterlson
bterlson approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@bterlson bterlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thank god.

@timotheeguerin timotheeguerin enabled auto-merge (squash) March 1, 2024 20:32
@timotheeguerin timotheeguerin changed the title Fix dup doc Fix duplicate docs in hover or completion details Mar 1, 2024
@azure-sdk
Copy link
Collaborator

You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/2976/

Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/2976/

@timotheeguerin timotheeguerin merged commit 01ba99b into microsoft:main Mar 1, 2024
14 checks passed
@timotheeguerin timotheeguerin deleted the fix/dup-doc branch March 1, 2024 20:50
markcowl pushed a commit to markcowl/cadl that referenced this pull request Mar 8, 2024
@timotheeguerin @markcowl
Fix dup doc (microsoft#2976)
f84ff3e 
Before
<img width="465" alt="image"
src="https://github.com/microsoft/typespec/assets/1031227/b620cac2-b70a-4a99-a784-bf03d55bd28b">

Now
<img width="413" alt="image"
src="https://github.com/microsoft/typespec/assets/1031227/d2a0b293-7924-44e7-9e1c-036ff40f1b6d">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bterlson bterlson bterlson approved these changes

@daviwil daviwil Awaiting requested review from daviwil

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timotheeguerin @azure-sdk @bterlson