-
Notifications
You must be signed in to change notification settings - Fork 382
Fix formatting of union #2441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
timotheeguerin
merged 15 commits into
microsoft:main
from
timotheeguerin:fix/format-union
Sep 20, 2023
Merged
Fix formatting of union #2441
Changes from 2 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7600122
fix formatting of union
timotheeguerin 3e135c6
Changelog
timotheeguerin 8c31dd6
Update common/changes/@typespec/compiler/fix-format-union_2023-09-19-…
timotheeguerin ea2c6b7
Fix
timotheeguerin 3261412
Merge branch 'main' into fix/format-union
timotheeguerin 832d26d
Update packages/compiler/test/formatter/formatter.test.ts
timotheeguerin 04ce198
remove
timotheeguerin 441e8af
Merge branch 'main' into fix/format-union
timotheeguerin c3b6c40
fix
timotheeguerin 7e4fe84
Enum and union follow the same rule
timotheeguerin d87e39a
format
timotheeguerin 10a0a4e
Merge branch 'main' into fix/format-union
timotheeguerin a484afa
changelog
timotheeguerin a5a2fda
Merge branch 'main' into fix/format-union
timotheeguerin ccb934a
Merge branch 'fix/format-union' of https://github.com/timotheeguerin/…
timotheeguerin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
10 changes: 10 additions & 0 deletions
10
common/changes/@typespec/compiler/fix-format-union_2023-09-19-19-07.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "@typespec/compiler", | ||
| "comment": "Fix: Union with anonymous variant were formatted with an extra leading `:`", | ||
| "type": "none" | ||
| } | ||
| ], | ||
| "packageName": "@typespec/compiler" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.