Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpPart explicit name should win over the property name if provided #3779

Closed
Tracked by #960
timotheeguerin opened this issue Jul 9, 2024 · 0 comments · Fixed by #3909
Closed
Tracked by #960

HttpPart explicit name should win over the property name if provided #3779

timotheeguerin opened this issue Jul 9, 2024 · 0 comments · Fixed by #3909
Assignees
@timotheeguerin
Labels
bug Something isn't working lib:http triaged:core
Milestone
[2024] August

Comments

@timotheeguerin
Copy link
Member

From the design #3046 the order of precedence for deciding the part name should have been

  1. The explicitly provided name on the part
  2. Name of the property in the object form

but current implementation did it the other way around

Playground Link
@timotheeguerin timotheeguerin added the bug Something isn't working label Jul 9, 2024
@msyyc msyyc mentioned this issue Jul 11, 2024
Merged
@markcowl markcowl added this to the [2024] August milestone Jul 16, 2024
@timotheeguerin timotheeguerin self-assigned this Jul 19, 2024
@timotheeguerin timotheeguerin mentioned this issue Jul 19, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 30, 2024
@timotheeguerin
Fix HttpPart not respecting part name (#3909)
44ffaf7 
fix  [#3779](#3779)

Fixing this issue where the property name always won against the
explicit part name for naming the part over the wire. This was the
opposite of what the design said.
@msyyc msyyc mentioned this issue Jul 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timotheeguerin timotheeguerin

Labels
bug Something isn't working lib:http triaged:core
Projects
None yet
Milestone
[2024] August
Development

Successfully merging a pull request may close this issue.

Fix HttpPart not respecting part name timotheeguerin/typespec
2 participants
@timotheeguerin @markcowl