Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Model properties called const without backticks no longer valid - undocumented breaking change in 0.57 #3583

Closed
4 tasks done
adamscybot opened this issue Jun 14, 2024 · 2 comments · Fixed by #3584
Closed
4 tasks done
Assignees
Labels
bug Something isn't working needs-area

Comments

@adamscybot
Copy link

adamscybot commented Jun 14, 2024

Describe the bug

Since 0.57 a model with a property (incidentally) called const no longer compiles unless it is wrapped in backticks.

In 0.56 this was allowed. In 0.57, presumably the change has come about because of the new const language functionality.

I have assumed here that this is therefore an intentional behavioural change, so have concluded it's just missing from the release notes 🙂. This had me confused for a little while.

But also probably need someone to chime in in case this wasn't actually expected.

Reproduction

As you can see between first two repro's theres a potential breaking change here.

Checklist

@adamscybot adamscybot added the bug Something isn't working label Jun 14, 2024
@timotheeguerin
Copy link
Member

Hhm this is a good point I’ll add that in the release notes, we are planning to relax use of keyword in some context like model property to both reduce those breaking changes in the future as well as be less confusing for new users.

@bterlson
Copy link
Member

Yeah we really gotta allow keywords as member names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-area
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants