Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OpenAPI 3] Emitter crashes with templated union #2946

Closed
bterlson opened this issue Feb 22, 2024 · 1 comment · Fixed by #3052
Closed

[OpenAPI 3] Emitter crashes with templated union #2946

bterlson opened this issue Feb 22, 2024 · 1 comment · Fixed by #3052
Assignees
@timotheeguerin
Labels
bug Something isn't working triaged:core
Milestone
[2024] April

Comments

@bterlson
Copy link
Member

Playground

union Response<T> {
  T;
  { hi: "there" };
}
@markcowl markcowl mentioned this issue Feb 22, 2024
Closed
@markcowl markcowl added this to the [2024] April milestone Feb 22, 2024
@markcowl markcowl added bug Something isn't working triaged:core and removed needs-area labels Feb 22, 2024
@timotheeguerin
Copy link
Member

Error seems to be in the compiler where we don't resolve template Parameter in union, error also in json schema emitter playground

@timotheeguerin timotheeguerin self-assigned this Mar 26, 2024
@timotheeguerin timotheeguerin mentioned this issue Mar 26, 2024
Merged
timotheeguerin added a commit that referenced this issue Mar 28, 2024
@timotheeguerin
Union template declaration were being finished in projector (#3052)
85fa7ae 
fix [#2946](#2946)

Problem was that in the projector were were calling to this helper to
see if that was a type that we should finish but it was missing the
union case causing union template declaration from being finished in the
projector and then being shown as finished type in the semantic
navigator and crashing openapi3 emitter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timotheeguerin timotheeguerin

Labels
bug Something isn't working triaged:core
Projects
None yet
Milestone
[2024] April
Development

Successfully merging a pull request may close this issue.

Union template declaration were being finished in projector timotheeguerin/typespec
3 participants
@bterlson @timotheeguerin @markcowl