Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow multiple @useAuth usage #2787

Closed
catalinaperalta opened this issue Jan 10, 2024 · 1 comment · Fixed by #2958
Closed

Disallow multiple @useAuth usage #2787

catalinaperalta opened this issue Jan 10, 2024 · 1 comment · Fixed by #2958
Assignees
@timotheeguerin
Labels
bug Something isn't working triaged:core
Milestone
[2024] March

Comments

@catalinaperalta
Copy link
Member

catalinaperalta commented Jan 10, 2024 •
edited
Loading

Currently, having multiple @useAuth decorators for a service definition only takes the first one and ignores the second, see: Playground example

If this syntax is not supported we should have a linter rule warning against this.
@timotheeguerin
Copy link
Member

Might just need to call the validateUniqueOnNode helper for that decorator.

@markcowl markcowl added bug Something isn't working and removed needs-area labels Jan 11, 2024
@markcowl markcowl added this to the [2024] February milestone Jan 11, 2024
@markcowl markcowl changed the title Add linter rule for multiple @useAuth usage Disallow multiple @useAuth usage Jan 11, 2024
This was referenced Jan 12, 2024
Merged
Merged
@timotheeguerin timotheeguerin mentioned this issue Feb 27, 2024
Merged
@timotheeguerin timotheeguerin self-assigned this Feb 27, 2024
timotheeguerin added a commit that referenced this issue Feb 28, 2024
@timotheeguerin @bterlson
Validate @useAuth is unique on node (#2958)
c9c1f3e 
fix #2787 

having multiple has no effect, the latest value will override the
previous ones so there is no reason to use `@useAuth` twice on the same
node

---------

Co-authored-by: Brian Terlson <[email protected]>
markcowl pushed a commit to markcowl/cadl that referenced this issue Mar 8, 2024
@timotheeguerin @bterlson @markcowl
Validate @useAuth is unique on node (microsoft#2958)
bd50004 
fix microsoft#2787 

having multiple has no effect, the latest value will override the
previous ones so there is no reason to use `@useAuth` twice on the same
node

---------

Co-authored-by: Brian Terlson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timotheeguerin timotheeguerin

Labels
bug Something isn't working triaged:core
Projects
None yet
Milestone
[2024] March
Development

Successfully merging a pull request may close this issue.

Validate @useAuth is unique on node timotheeguerin/typespec
3 participants
@timotheeguerin @markcowl @catalinaperalta