Include template arguments for operation in intellisense (#3183)

fix #2423 Include template arguments for operation in intellisense --------- Co-authored-by: Timothee Guerin <[email protected]>
microsoft · Apr 18, 2024 · 9fcc90f · 9fcc90f
1 parent 1265330
commit 9fcc90f
Show file tree

Hide file tree

Showing 6 changed files with 484 additions and 6 deletions.
diff --git a/.chronus/changes/fix-include-op-template-args-2024-3-16-17-19-2.md b/.chronus/changes/fix-include-op-template-args-2024-3-16-17-19-2.md
@@ -0,0 +1,7 @@
+---
+changeKind: feature
+packages:
+  - "@typespec/compiler"
+---
+
+Show template parameters when hovering on an operation template
diff --git a/packages/compiler/src/core/helpers/type-name-utils.ts b/packages/compiler/src/core/helpers/type-name-utils.ts
@@ -182,7 +182,16 @@ function getInterfaceName(iface: Interface, options: TypeNameOptions | undefined
 }
 
 function getOperationName(op: Operation, options: TypeNameOptions | undefined) {
-  return `${getNamespacePrefix(op.namespace, options)}${getIdentifierName(op.name, options)}`;
+  let opName = getIdentifierName(op.name, options);
+  if (op.node.templateParameters.length > 0) {
+    // template
+    const params = op.node.templateParameters.map((t) => getIdentifierName(t.id.sv, options));
+    opName += `<${params.join(", ")}>`;
+  }
+  const prefix = op.interface
+    ? getInterfaceName(op.interface, options) + "."
+    : getNamespacePrefix(op.namespace, options);
+  return `${prefix}${opName}`;
 }
 
 function getIdentifierName(name: string, options: TypeNameOptions | undefined) {

diff --git a/packages/compiler/src/server/type-signature.ts b/packages/compiler/src/server/type-signature.ts
@@ -99,9 +99,8 @@ function getFunctionSignature(type: FunctionType) {
 }
 
 function getOperationSignature(type: Operation) {
-  const ns = getQualifier(type.namespace) || getQualifier(type.interface);
   const parameters = [...type.parameters.properties.values()].map(getModelPropertySignature);
-  return `op ${ns}${type.name}(${parameters.join(", ")}): ${getPrintableTypeName(type.returnType)}`;
+  return `op ${getTypeName(type)}(${parameters.join(", ")}): ${getPrintableTypeName(type.returnType)}`;
 }
 
 function getFunctionParameterSignature(parameter: FunctionParameter) {

diff --git a/packages/compiler/test/projection/projector-identity.test.ts b/packages/compiler/test/projection/projector-identity.test.ts
@@ -285,7 +285,7 @@ describe("compiler: projector: Identity", () => {
           }`,
         ref: "Foo.one",
         expectedTypes: [
-          ["Operation", "one"],
+          ["Operation", "Foo.one"],
           ["Interface", "Foo"],
         ],
       });