Sort numeric symbols #690
Sort numeric symbols #690
Conversation
# Conflicts: # testdata/baselines/reference/submodule/compiler/mappedTypeIndexedAccessConstraint.types # testdata/baselines/reference/submodule/compiler/mappedTypeIndexedAccessConstraint.types.diff # testdata/baselines/reference/submodule/compiler/objectLiteralIndexerErrors.types.diff # testdata/baselines/reference/submodule/compiler/objectLiteralIndexers.types.diff # testdata/baselines/reference/submodule/compiler/propertiesAndIndexers.types.diff # testdata/baselines/reference/submodule/conformance/objectTypeWithStringNamedNumericProperty.types.diff
| return -1 | ||
| } | ||
| int1, err1 := strconv.Atoi(s1.Name) | ||
| int2, err2 := strconv.Atoi(s2.Name) |
There was a problem hiding this comment.
I'm afraid it's not that simple. Consider symbols named "0", "00", and "000" and so on! We'd want a check that the symbol round-trips as a number. Which unfortunately is a more expensive check.
There was a problem hiding this comment.
Good point, I can implement that - as long as it's even something you'd like to see getting in. At the moment, the main user-oriented improvement in this is a better error message here: testdata/baselines/reference/submodule/conformance/arityAndOrderCompatibility01.errors.txt. But at the same time, this test case isn't exercising a particularly popular pattern.
|
@Andarist it sounds like this change might be too expensive if you put in the work to correct it. Do you want to keep working on this PR? Or should we close it? |
3 participants
@jakebailey mentioned this is something the team is considering to do.