Set implied node format during source file creation

internal/ast/ast.go

@@ -8695,6 +8695,8 @@ type SourceFile struct {
 	ReferencedFiles             []*FileReference
 	TypeReferenceDirectives     []*FileReference
 	LibReferenceDirectives      []*FileReference
+	PackageJsonType             string
+	ImpliedNodeFormat           core.ModuleKind
 
 	// Fields set by binder
 
@@ -8723,7 +8725,6 @@ type SourceFile struct {
 
 	// !!!
 
-	ImpliedNodeFormat       core.ModuleKind
 	CommonJsModuleIndicator *Node
 	ExternalModuleIndicator *Node
 	JsGlobalAugmentations   SymbolTable

internal/ast/utilities.go

@@ -2368,13 +2368,13 @@ func GetImpliedNodeFormatForEmitWorker(sourceFile *SourceFile, options *core.Com
 		return sourceFile.ImpliedNodeFormat
 	}
 	if sourceFile.ImpliedNodeFormat == core.ModuleKindCommonJS &&
-		( /*sourceFile.packageJsonScope.contents.packageJsonContent.type == "commonjs" ||*/ // !!!
-		tspath.FileExtensionIsOneOf(sourceFile.FileName(), []string{tspath.ExtensionCjs, tspath.ExtensionCts})) {
+		(sourceFile.PackageJsonType != "module" ||
+			tspath.FileExtensionIsOneOf(sourceFile.FileName(), []string{tspath.ExtensionCjs, tspath.ExtensionCts})) {
 		return core.ModuleKindCommonJS
 	}
 	if sourceFile.ImpliedNodeFormat == core.ModuleKindESNext &&
-		( /*sourceFile.packageJsonScope?.contents.packageJsonContent.type === "module" ||*/ // !!!
-		tspath.FileExtensionIsOneOf(sourceFile.fileName, []string{tspath.ExtensionMjs, tspath.ExtensionMts})) {
+		(sourceFile.PackageJsonType == "module" ||
+			tspath.FileExtensionIsOneOf(sourceFile.fileName, []string{tspath.ExtensionMjs, tspath.ExtensionMts})) {
 		return core.ModuleKindESNext
 	}
 	return core.ModuleKindNone

internal/astnav/tokens_test.go

@@ -52,7 +52,7 @@ func TestGetTokenAtPosition(t *testing.T) {
 				return 0;
 			}
 		`
-		file := parser.ParseSourceFile("/file.ts", "/file.ts", fileText, core.ScriptTargetLatest, scanner.JSDocParsingModeParseAll)
+		file := parser.ParseSourceFile("/file.ts", "/file.ts", fileText, core.ScriptTargetLatest, scanner.JSDocParsingModeParseAll, core.ModuleResolutionKindNodeNext, "")
 		assert.Equal(t, astnav.GetTokenAtPosition(file, 0), astnav.GetTokenAtPosition(file, 0))
 	})
 }
@@ -86,7 +86,7 @@ func baselineTokens(t *testing.T, testName string, getTSTokens func(fileText str
 				positions[i] = i
 			}
 			tsTokens := getTSTokens(string(fileText), positions)
-			file := parser.ParseSourceFile("/file.ts", "/file.ts", string(fileText), core.ScriptTargetLatest, scanner.JSDocParsingModeParseAll)
+			file := parser.ParseSourceFile("/file.ts", "/file.ts", string(fileText), core.ScriptTargetLatest, scanner.JSDocParsingModeParseAll, core.ModuleResolutionKindNodeNext, "")
 
 			var output strings.Builder
 			currentRange := core.NewTextRange(0, 0)

internal/binder/binder_test.go

@@ -24,7 +24,7 @@ func BenchmarkBind(b *testing.B) {
 
 			sourceFiles := make([]*ast.SourceFile, b.N)
 			for i := range b.N {
-				sourceFiles[i] = parser.ParseSourceFile(fileName, path, sourceText, core.ScriptTargetESNext, scanner.JSDocParsingModeParseAll)
+				sourceFiles[i] = parser.ParseSourceFile(fileName, path, sourceText, core.ScriptTargetESNext, scanner.JSDocParsingModeParseAll, core.ModuleResolutionKindNodeNext, "")
 			}
 
 			compilerOptions := &core.CompilerOptions{Target: core.ScriptTargetESNext, ModuleKind: core.ModuleKindNodeNext}

internal/compiler/fileloader.go

@@ -223,7 +223,12 @@ func (t *parseTask) start(loader *fileLoader) {
 
 func (p *fileLoader) parseSourceFile(fileName string) *ast.SourceFile {
 	path := tspath.ToPath(fileName, p.host.GetCurrentDirectory(), p.host.FS().UseCaseSensitiveFileNames())
-	sourceFile := p.host.GetSourceFile(fileName, path, p.compilerOptions.GetEmitScriptTarget())
+	packageType := ""
+	packageScope := p.resolver.GetPackageScopeForPath(fileName)
+	if packageScope != nil {
+		packageType = packageScope.Contents.Type.Value
+	}
+	sourceFile := p.host.GetSourceFile(fileName, path, p.compilerOptions.GetEmitScriptTarget(), packageType)
 	return sourceFile
 }
 

internal/compiler/host.go

@@ -15,7 +15,7 @@ type CompilerHost interface {
 	GetCurrentDirectory() string
 	NewLine() string
 	Trace(msg string)
-	GetSourceFile(fileName string, path tspath.Path, languageVersion core.ScriptTarget) *ast.SourceFile
+	GetSourceFile(fileName string, path tspath.Path, languageVersion core.ScriptTarget, packageJsonType string) *ast.SourceFile
 }
 
 type FileInfo struct {
@@ -68,10 +68,16 @@ func (h *compilerHost) Trace(msg string) {
 	//!!! TODO: implement
 }
 
-func (h *compilerHost) GetSourceFile(fileName string, path tspath.Path, languageVersion core.ScriptTarget) *ast.SourceFile {
+func (h *compilerHost) GetSourceFile(fileName string, path tspath.Path, languageVersion core.ScriptTarget, packageJsonType string) *ast.SourceFile {
 	text, _ := h.FS().ReadFile(fileName)
 	if tspath.FileExtensionIs(fileName, tspath.ExtensionJson) {
 		return parser.ParseJSONText(fileName, path, text)
 	}
-	return parser.ParseSourceFile(fileName, path, text, languageVersion, scanner.JSDocParsingModeParseForTypeErrors)
+
+	var moduleResolutionKind core.ModuleResolutionKind
+	if h.options != nil {
+		moduleResolutionKind = h.options.GetModuleResolutionKind()
+	}
+
+	return parser.ParseSourceFile(fileName, path, text, languageVersion, scanner.JSDocParsingModeParseForTypeErrors, moduleResolutionKind, packageJsonType)
 }

internal/ls/host.go

@@ -19,7 +19,7 @@ type Host interface {
 	GetRootFileNames() []string
 	// GetCompilerOptions was called GetCompilationSettings in the original code.
 	GetCompilerOptions() *core.CompilerOptions
-	GetSourceFile(fileName string, path tspath.Path, languageVersion core.ScriptTarget) *ast.SourceFile
+	GetSourceFile(fileName string, path tspath.Path, languageVersion core.ScriptTarget, packageJsonType string) *ast.SourceFile
 	// This responsibility was moved from the language service to the project,
 	// because they were bidirectionally interdependent.
 	GetProgram() *compiler.Program

internal/ls/languageservice.go

@@ -46,8 +46,8 @@ func (l *LanguageService) Trace(msg string) {
 }
 
 // GetSourceFile implements compiler.CompilerHost.
-func (l *LanguageService) GetSourceFile(fileName string, path tspath.Path, languageVersion core.ScriptTarget) *ast.SourceFile {
-	return l.host.GetSourceFile(fileName, path, languageVersion)
+func (l *LanguageService) GetSourceFile(fileName string, path tspath.Path, languageVersion core.ScriptTarget, packageJsonType string) *ast.SourceFile {
+	return l.host.GetSourceFile(fileName, path, languageVersion, packageJsonType)
 }
 
 // GetProgram updates the program if the project version has changed.

internal/parser/parser.go

@@ -51,14 +51,16 @@ type Parser struct {
 	scanner *scanner.Scanner
 	factory ast.NodeFactory
 
-	fileName         string
-	path             tspath.Path
-	sourceText       string
-	languageVersion  core.ScriptTarget
-	scriptKind       core.ScriptKind
-	languageVariant  core.LanguageVariant
-	diagnostics      []*ast.Diagnostic
-	jsdocDiagnostics []*ast.Diagnostic
+	fileName          string
+	path              tspath.Path
+	sourceText        string
+	languageVersion   core.ScriptTarget
+	scriptKind        core.ScriptKind
+	languageVariant   core.LanguageVariant
+	diagnostics       []*ast.Diagnostic
+	jsdocDiagnostics  []*ast.Diagnostic
+	impliedNodeFormat core.ResolutionMode
+	packageJsonType   string
 
 	token                       ast.Kind
 	sourceFlags                 ast.NodeFlags
@@ -92,18 +94,18 @@ func putParser(p *Parser) {
 	parserPool.Put(p)
 }
 
-func ParseSourceFile(fileName string, path tspath.Path, sourceText string, languageVersion core.ScriptTarget, jsdocParsingMode scanner.JSDocParsingMode) *ast.SourceFile {
+func ParseSourceFile(fileName string, path tspath.Path, sourceText string, languageVersion core.ScriptTarget, jsdocParsingMode scanner.JSDocParsingMode, moduleResolutionKind core.ModuleResolutionKind, packageJsonType string) *ast.SourceFile {
 	p := getParser()
 	defer putParser(p)
-	p.initializeState(fileName, path, sourceText, languageVersion, core.ScriptKindUnknown, jsdocParsingMode)
+	p.initializeState(fileName, path, sourceText, languageVersion, core.ScriptKindUnknown, jsdocParsingMode, moduleResolutionKind, packageJsonType)
 	p.nextToken()
 	return p.parseSourceFileWorker()
 }
 
 func ParseJSONText(fileName string, path tspath.Path, sourceText string) *ast.SourceFile {
 	p := getParser()
 	defer putParser(p)
-	p.initializeState(fileName, path, sourceText, core.ScriptTargetES2015, core.ScriptKindJSON, scanner.JSDocParsingModeParseAll)
+	p.initializeState(fileName, path, sourceText, core.ScriptTargetES2015, core.ScriptKindJSON, scanner.JSDocParsingModeParseAll, core.ModuleResolutionKindUnknown, "")
 	p.nextToken()
 	pos := p.nodePos()
 	var statements *ast.NodeList
@@ -176,7 +178,7 @@ func ParseJSONText(fileName string, path tspath.Path, sourceText string) *ast.So
 	return result
 }
 
-func (p *Parser) initializeState(fileName string, path tspath.Path, sourceText string, languageVersion core.ScriptTarget, scriptKind core.ScriptKind, jsdocParsingMode scanner.JSDocParsingMode) {
+func (p *Parser) initializeState(fileName string, path tspath.Path, sourceText string, languageVersion core.ScriptTarget, scriptKind core.ScriptKind, jsdocParsingMode scanner.JSDocParsingMode, moduleResolutionKind core.ModuleResolutionKind, packageJsonType string) {
 	if p.scanner == nil {
 		p.scanner = scanner.NewScanner()
 	} else {
@@ -196,6 +198,20 @@ func (p *Parser) initializeState(fileName string, path tspath.Path, sourceText s
 	default:
 		p.contextFlags = ast.NodeFlagsNone
 	}
+
+	shouldLookupFromPackageJson := core.ModuleResolutionKindNode16 <= moduleResolutionKind && moduleResolutionKind <= core.ModuleResolutionKindNodeNext || strings.Contains(string(path), "/node_modules/")
+
+	impliedNodeFormat := core.ResolutionModeNone
+	if tspath.FileExtensionIsOneOf(string(path), []string{tspath.ExtensionDmts, tspath.ExtensionMts, tspath.ExtensionMjs}) {
+		impliedNodeFormat = core.ResolutionModeESM
+	} else if tspath.FileExtensionIsOneOf(string(path), []string{tspath.ExtensionDcts, tspath.ExtensionCts, tspath.ExtensionCjs}) {
+		impliedNodeFormat = core.ResolutionModeCommonJS
+	} else if shouldLookupFromPackageJson && tspath.FileExtensionIsOneOf(string(path), []string{tspath.ExtensionDts, tspath.ExtensionTs, tspath.ExtensionTsx, tspath.ExtensionJs, tspath.ExtensionJsx}) {
+		impliedNodeFormat = core.IfElse(packageJsonType == "module", core.ResolutionModeESM, core.ResolutionModeCommonJS)
+	}
+
+	p.impliedNodeFormat = impliedNodeFormat
+	p.packageJsonType = packageJsonType
 	p.scanner.SetText(p.sourceText)
 	p.scanner.SetOnError(p.scanError)
 	p.scanner.SetScriptTarget(p.languageVersion)
@@ -325,8 +341,12 @@ func (p *Parser) finishSourceFile(result *ast.SourceFile, isDeclarationFile bool
 	result.Flags |= p.sourceFlags
 	result.Identifiers = p.identifiers
 	result.SetJSDocCache(p.jsdocCache)
+	result.ImpliedNodeFormat = p.impliedNodeFormat
+	result.PackageJsonType = p.packageJsonType
 	p.jsdocCache = nil
 	p.identifiers = nil
+	p.impliedNodeFormat = core.ResolutionModeNone
+	p.packageJsonType = ""
 }
 
 func (p *Parser) parseToplevelStatement(i int) *ast.Node {

internal/parser/parser_test.go

@@ -39,7 +39,7 @@ func BenchmarkParse(b *testing.B) {
 				b.Run(jsdoc.name, func(b *testing.B) {
 					jsdocMode := jsdoc.mode
 					for b.Loop() {
-						ParseSourceFile(fileName, path, sourceText, core.ScriptTargetESNext, jsdocMode)
+						ParseSourceFile(fileName, path, sourceText, core.ScriptTargetESNext, jsdocMode, core.ModuleResolutionKindNodeNext, "")
 					}
 				})
 			}
@@ -82,7 +82,7 @@ func TestParseTypeScriptRepo(t *testing.T) {
 					if strings.HasSuffix(f.name, ".json") {
 						sourceFile = ParseJSONText(fileName, path, string(sourceText))
 					} else {
-						sourceFile = ParseSourceFile(fileName, path, string(sourceText), core.ScriptTargetESNext, scanner.JSDocParsingModeParseAll)
+						sourceFile = ParseSourceFile(fileName, path, string(sourceText), core.ScriptTargetESNext, scanner.JSDocParsingModeParseAll, core.ModuleResolutionKindNodeNext, "")
 					}
 
 					if !test.ignoreErrors {
@@ -179,6 +179,6 @@ func FuzzParser(f *testing.F) {
 			return
 		}
 
-		ParseSourceFile(fileName, path, sourceText, scriptTarget, jsdocParsingMode)
+		ParseSourceFile(fileName, path, sourceText, scriptTarget, jsdocParsingMode, core.ModuleResolutionKindUnknown, "")
 	})
 }

internal/project/documentregistry.go

@@ -87,12 +87,16 @@ func (r *documentRegistry) getDocumentWorker(
 	key registryKey,
 ) *ast.SourceFile {
 	scriptTarget := core.IfElse(scriptInfo.scriptKind == core.ScriptKindJSON, core.ScriptTargetJSON, compilerOptions.GetEmitScriptTarget())
+	var moduleResolutionKind core.ModuleResolutionKind
+	if compilerOptions != nil {
+		moduleResolutionKind = compilerOptions.GetModuleResolutionKind()
+	}
 	if entryAny, ok := r.documents.Load(key); ok {
 		// We have an entry for this file. However, it may be for a different version of
 		// the script snapshot. If so, update it appropriately.
 		entry := entryAny.(*registryEntry)
 		if entry.sourceFile.Version != scriptInfo.version {
-			sourceFile := parser.ParseSourceFile(scriptInfo.fileName, scriptInfo.path, scriptInfo.text, scriptTarget, scanner.JSDocParsingModeParseAll)
+			sourceFile := parser.ParseSourceFile(scriptInfo.fileName, scriptInfo.path, scriptInfo.text, scriptTarget, scanner.JSDocParsingModeParseAll, moduleResolutionKind, "")
 			sourceFile.Version = scriptInfo.version
 			entry.mu.Lock()
 			defer entry.mu.Unlock()
@@ -102,7 +106,7 @@ func (r *documentRegistry) getDocumentWorker(
 		return entry.sourceFile
 	} else {
 		// Have never seen this file with these settings. Create a new source file for it.
-		sourceFile := parser.ParseSourceFile(scriptInfo.fileName, scriptInfo.path, scriptInfo.text, scriptTarget, scanner.JSDocParsingModeParseAll)
+		sourceFile := parser.ParseSourceFile(scriptInfo.fileName, scriptInfo.path, scriptInfo.text, scriptTarget, scanner.JSDocParsingModeParseAll, moduleResolutionKind, "")
 		sourceFile.Version = scriptInfo.version
 		entryAny, _ := r.documents.LoadOrStore(key, &registryEntry{
 			sourceFile: sourceFile,

internal/project/project.go

@@ -124,7 +124,7 @@ func (p *Project) GetRootFileNames() []string {
 }
 
 // GetSourceFile implements LanguageServiceHost.
-func (p *Project) GetSourceFile(fileName string, path tspath.Path, languageVersion core.ScriptTarget) *ast.SourceFile {
+func (p *Project) GetSourceFile(fileName string, path tspath.Path, languageVersion core.ScriptTarget, packageJsonType string) *ast.SourceFile {
 	scriptKind := p.getScriptKind(fileName)
 	if scriptInfo := p.getOrCreateScriptInfoAndAttachToProject(fileName, scriptKind); scriptInfo != nil {
 		var (

internal/testutil/harnessutil/harnessutil.go

@@ -355,14 +355,15 @@ type cachedCompilerHost struct {
 
 var sourceFileCache sync.Map
 
-func (h *cachedCompilerHost) GetSourceFile(fileName string, path tspath.Path, languageVersion core.ScriptTarget) *ast.SourceFile {
+func (h *cachedCompilerHost) GetSourceFile(fileName string, path tspath.Path, languageVersion core.ScriptTarget, packageJsonType string) *ast.SourceFile {
 	text, _ := h.FS().ReadFile(fileName)
 
 	type sourceFileCacheKey struct {
 		core.SourceFileAffectingCompilerOptions
 		fileName        string
 		path            tspath.Path
 		languageVersion core.ScriptTarget
+		packageJsonType string
 		text            string
 	}
 
@@ -371,6 +372,7 @@ func (h *cachedCompilerHost) GetSourceFile(fileName string, path tspath.Path, la
 		fileName:                           fileName,
 		path:                               path,
 		languageVersion:                    languageVersion,
+		packageJsonType:                    packageJsonType,
 		text:                               text,
 	}
 
@@ -384,7 +386,12 @@ func (h *cachedCompilerHost) GetSourceFile(fileName string, path tspath.Path, la
 		sourceFile = parser.ParseJSONText(fileName, path, text)
 	} else {
 		// !!! JSDocParsingMode
-		sourceFile = parser.ParseSourceFile(fileName, path, text, languageVersion, scanner.JSDocParsingModeParseAll)
+		var moduleResolutionKind core.ModuleResolutionKind
+		if h.options != nil {
+			moduleResolutionKind = h.options.GetModuleResolutionKind()
+		}
+
+		sourceFile = parser.ParseSourceFile(fileName, path, text, languageVersion, scanner.JSDocParsingModeParseAll, moduleResolutionKind, packageJsonType)
 	}
 
 	result, _ := sourceFileCache.LoadOrStore(key, sourceFile)

internal/testutil/parsetestutil/parsetestutil.go

@@ -15,7 +15,7 @@ import (
 // Simplifies parsing an input string into a SourceFile for testing purposes.
 func ParseTypeScript(text string, jsx bool) *ast.SourceFile {
 	fileName := core.IfElse(jsx, "/main.tsx", "/main.ts")
-	file := parser.ParseSourceFile(fileName, tspath.Path(fileName), text, core.ScriptTargetESNext, scanner.JSDocParsingModeParseNone)
+	file := parser.ParseSourceFile(fileName, tspath.Path(fileName), text, core.ScriptTargetESNext, scanner.JSDocParsingModeParseNone, core.ModuleResolutionKindNodeNext, "")
 	ast.SetParentInChildren(file.AsNode())
 	return file
 }

testdata/baselines/reference/submodule/compiler/esmModeDeclarationFileWithExportAssignment.errors.txt

@@ -0,0 +1,12 @@
+other.d.mts(2,1): error TS1203: Export assignment cannot be used when targeting ECMAScript modules. Consider using 'export default' or another module format instead.
+
+
+==== other.d.mts (1 errors) ====
+    declare function example(): 5;
+    export = example;
+    ~~~~~~~~~~~~~~~~~
+!!! error TS1203: Export assignment cannot be used when targeting ECMAScript modules. Consider using 'export default' or another module format instead.
+
+==== main.mts (0 errors) ====
+    import example from "./other.mjs";
+    example();

testdata/baselines/reference/submodule/compiler/esmModeDeclarationFileWithExportAssignment.errors.txt.diff

@@ -1,20 +1,17 @@
 --- old.esmModeDeclarationFileWithExportAssignment.errors.txt
 +++ new.esmModeDeclarationFileWithExportAssignment.errors.txt
-@@= skipped -0, +-1 lines =@@
+@@= skipped -0, +0 lines =@@
 -main.mts(1,8): error TS1192: Module '"other"' has no default export.
--other.d.mts(2,1): error TS1203: Export assignment cannot be used when targeting ECMAScript modules. Consider using 'export default' or another module format instead.
--
--
--==== other.d.mts (1 errors) ====
--    declare function example(): 5;
--    export = example;
--    ~~~~~~~~~~~~~~~~~
--!!! error TS1203: Export assignment cannot be used when targeting ECMAScript modules. Consider using 'export default' or another module format instead.
--    
+ other.d.mts(2,1): error TS1203: Export assignment cannot be used when targeting ECMAScript modules. Consider using 'export default' or another module format instead.
+
+
+@@= skipped -7, +6 lines =@@
+     ~~~~~~~~~~~~~~~~~
+ !!! error TS1203: Export assignment cannot be used when targeting ECMAScript modules. Consider using 'export default' or another module format instead.
+
 -==== main.mts (1 errors) ====
--    import example from "./other.mjs";
++==== main.mts (0 errors) ====
+     import example from "./other.mjs";
 -           ~~~~~~~
 -!!! error TS1192: Module '"other"' has no default export.
--    example();
-@@= skipped --1, +1 lines =@@
-+<no content>
+     example();