Port TypeScript PR #62950: Ignore computed name parents when looking up containing functions #2461
+51
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports microsoft/TypeScript#62950
When looking up containing functions from within a computed property name (e.g.,
[yield 0]), the compiler would incorrectly treat the method being defined as the containing function, causing infinite recursion during contextual typing.Changes
GetContainingFunction(internal/ast/utilities.go): Skip overComputedPropertyNamenodes by jumping tonode.Parent.ParentgetContainingFunctionOrClassStaticBlock(internal/checker/utilities.go): Same fixgetContainingClassStaticBlock(internal/checker/utilities.go): Added new function with same computed property name handling, for parity with TypeScriptThis also fixes
awaitexpressions in computed property names inside class static blocks now correctly reporting errors.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.