fix(2426): goToDefinition for pattern ambient module no longer goes to implementation #2429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
reviewed
Jan 13, 2026
Member
|
PR is failing because the failing tests need to be updated |
jakebailey
reviewed
Jan 13, 2026
internal/fourslash/tests/manual/semicolonFormattingInsideAStringLiteral_test.go
Outdated
Show resolved
Hide resolved
jakebailey
approved these changes
Jan 13, 2026
auto-merge was automatically disabled
January 13, 2026 09:29
Head branch was pushed to by a user without write access
jakebailey
approved these changes
Jan 13, 2026
gabritto
reviewed
Jan 13, 2026
| } | ||
| locations = append(locations, &lsproto.LocationLink{ | ||
| OriginSelectionRange: originSelectionRange, | ||
| TargetUri: lsconv.FileNameToDocumentURI(reference.fileName), |
Member
There was a problem hiding this comment.
Could this ever need to go through the source mapper?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2426