Skip to content

Add tests for GetNormalizedAbsolutePath. #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanielRosenwasser merged 1 commit into from
Dec 18, 2024
Merged

Add tests for GetNormalizedAbsolutePath. #192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
107 changes: 107 additions & 0 deletions internal/tspath/path_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,113 @@ func TestResolvePath(t *testing.T) {
assert.Equal(t, ResolvePath("a", "b", "../c"), "a/c")
}

func TestGetNormalizedAbsolutePath(t *testing.T) {
t.Parallel()

assert.Equal(t, GetNormalizedAbsolutePath("/", ""), "/")
assert.Equal(t, GetNormalizedAbsolutePath("/.", ""), "/")
assert.Equal(t, GetNormalizedAbsolutePath("/./", ""), "/")
assert.Equal(t, GetNormalizedAbsolutePath("/../", ""), "/")
assert.Equal(t, GetNormalizedAbsolutePath("/a", ""), "/a")
assert.Equal(t, GetNormalizedAbsolutePath("/a/", ""), "/a")
assert.Equal(t, GetNormalizedAbsolutePath("/a/.", ""), "/a")
assert.Equal(t, GetNormalizedAbsolutePath("/a/foo.", ""), "/a/foo.")
assert.Equal(t, GetNormalizedAbsolutePath("/a/./", ""), "/a")
assert.Equal(t, GetNormalizedAbsolutePath("/a/./b", ""), "/a/b")
assert.Equal(t, GetNormalizedAbsolutePath("/a/./b/", ""), "/a/b")
assert.Equal(t, GetNormalizedAbsolutePath("/a/..", ""), "/")
assert.Equal(t, GetNormalizedAbsolutePath("/a/../", ""), "/")
assert.Equal(t, GetNormalizedAbsolutePath("/a/../", ""), "/")
assert.Equal(t, GetNormalizedAbsolutePath("/a/../b", ""), "/b")
assert.Equal(t, GetNormalizedAbsolutePath("/a/../b/", ""), "/b")
assert.Equal(t, GetNormalizedAbsolutePath("/a/..", ""), "/")
assert.Equal(t, GetNormalizedAbsolutePath("/a/..", "/"), "/")
assert.Equal(t, GetNormalizedAbsolutePath("/a/..", "b/"), "/")
assert.Equal(t, GetNormalizedAbsolutePath("/a/..", "/b"), "/")
assert.Equal(t, GetNormalizedAbsolutePath("/a/.", "b"), "/a")
assert.Equal(t, GetNormalizedAbsolutePath("/a/.", "."), "/a")

// Tests as above, but with backslashes.
assert.Equal(t, GetNormalizedAbsolutePath("\\", ""), "/")
assert.Equal(t, GetNormalizedAbsolutePath("\\.", ""), "/")
assert.Equal(t, GetNormalizedAbsolutePath("\\.\\", ""), "/")
assert.Equal(t, GetNormalizedAbsolutePath("\\..\\", ""), "/")
assert.Equal(t, GetNormalizedAbsolutePath("\\a\\.\\", ""), "/a")
assert.Equal(t, GetNormalizedAbsolutePath("\\a\\.\\b", ""), "/a/b")
assert.Equal(t, GetNormalizedAbsolutePath("\\a\\.\\b\\", ""), "/a/b")
assert.Equal(t, GetNormalizedAbsolutePath("\\a\\..", ""), "/")
assert.Equal(t, GetNormalizedAbsolutePath("\\a\\..\\", ""), "/")
assert.Equal(t, GetNormalizedAbsolutePath("\\a\\..\\", ""), "/")
assert.Equal(t, GetNormalizedAbsolutePath("\\a\\..\\b", ""), "/b")
assert.Equal(t, GetNormalizedAbsolutePath("\\a\\..\\b\\", ""), "/b")
Copy link
Member

@jakebailey jakebailey Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like all of these backslash cases would benefit from using raw strings, but, I guess it's the same as the main TS repo

assert.Equal(t, GetNormalizedAbsolutePath("\\a\\..", ""), "/")
assert.Equal(t, GetNormalizedAbsolutePath("\\a\\..", "\\"), "/")
assert.Equal(t, GetNormalizedAbsolutePath("\\a\\..", "b\\"), "/")
assert.Equal(t, GetNormalizedAbsolutePath("\\a\\..", "\\b"), "/")
assert.Equal(t, GetNormalizedAbsolutePath("\\a\\.", "b"), "/a")
assert.Equal(t, GetNormalizedAbsolutePath("\\a\\.", "."), "/a")

// Relative paths on an empty currentDirectory.
assert.Equal(t, GetNormalizedAbsolutePath("", ""), "")
assert.Equal(t, GetNormalizedAbsolutePath(".", ""), "")
assert.Equal(t, GetNormalizedAbsolutePath("./", ""), "")
// Strangely, these do not normalize to the empty string.
assert.Equal(t, GetNormalizedAbsolutePath("..", ""), "..")
assert.Equal(t, GetNormalizedAbsolutePath("../", ""), "..")

// Interaction between relative paths and currentDirectory.
assert.Equal(t, GetNormalizedAbsolutePath("", "/home"), "/home")
assert.Equal(t, GetNormalizedAbsolutePath(".", "/home"), "/home")
assert.Equal(t, GetNormalizedAbsolutePath("./", "/home"), "/home")
assert.Equal(t, GetNormalizedAbsolutePath("..", "/home"), "/")
assert.Equal(t, GetNormalizedAbsolutePath("../", "/home"), "/")
assert.Equal(t, GetNormalizedAbsolutePath("a", "b"), "b/a")
assert.Equal(t, GetNormalizedAbsolutePath("a", "b/c"), "b/c/a")

// Base names starting or ending with a dot do not affect normalization.
assert.Equal(t, GetNormalizedAbsolutePath(".a", ""), ".a")
assert.Equal(t, GetNormalizedAbsolutePath("..a", ""), "..a")
assert.Equal(t, GetNormalizedAbsolutePath("a.", ""), "a.")
assert.Equal(t, GetNormalizedAbsolutePath("a..", ""), "a..")

assert.Equal(t, GetNormalizedAbsolutePath("/base/./.a", ""), "/base/.a")
assert.Equal(t, GetNormalizedAbsolutePath("/base/../.a", ""), "/.a")
assert.Equal(t, GetNormalizedAbsolutePath("/base/./..a", ""), "/base/..a")
assert.Equal(t, GetNormalizedAbsolutePath("/base/../..a", ""), "/..a")
assert.Equal(t, GetNormalizedAbsolutePath("/base/./..a/b", ""), "/base/..a/b")
assert.Equal(t, GetNormalizedAbsolutePath("/base/../..a/b", ""), "/..a/b")

assert.Equal(t, GetNormalizedAbsolutePath("/base/./a.", ""), "/base/a.")
assert.Equal(t, GetNormalizedAbsolutePath("/base/../a.", ""), "/a.")
assert.Equal(t, GetNormalizedAbsolutePath("/base/./a..", ""), "/base/a..")
assert.Equal(t, GetNormalizedAbsolutePath("/base/../a..", ""), "/a..")
assert.Equal(t, GetNormalizedAbsolutePath("/base/./a../b", ""), "/base/a../b")
assert.Equal(t, GetNormalizedAbsolutePath("/base/../a../b", ""), "/a../b")

// Consecutive intermediate slashes are normalized to a single slash.
assert.Equal(t, GetNormalizedAbsolutePath("a//b", ""), "a/b")
assert.Equal(t, GetNormalizedAbsolutePath("a///b", ""), "a/b")
assert.Equal(t, GetNormalizedAbsolutePath("a/b//c", ""), "a/b/c")
assert.Equal(t, GetNormalizedAbsolutePath("/a/b//c", ""), "/a/b/c")
assert.Equal(t, GetNormalizedAbsolutePath("//a/b//c", ""), "//a/b/c")

// Backslashes are converted to slashes,
// and then consecutive intermediate slashes are normalized to a single slash
assert.Equal(t, GetNormalizedAbsolutePath("a\\\\b", ""), "a/b")
assert.Equal(t, GetNormalizedAbsolutePath("a\\\\\\b", ""), "a/b")
assert.Equal(t, GetNormalizedAbsolutePath("a\\b\\\\c", ""), "a/b/c")
assert.Equal(t, GetNormalizedAbsolutePath("\\a\\b\\\\c", ""), "/a/b/c")
assert.Equal(t, GetNormalizedAbsolutePath("\\\\a\\b\\\\c", ""), "//a/b/c")

// The same occurs for mixed slashes.
assert.Equal(t, GetNormalizedAbsolutePath("a/\\b", ""), "a/b")
assert.Equal(t, GetNormalizedAbsolutePath("a\\/b", ""), "a/b")
assert.Equal(t, GetNormalizedAbsolutePath("a\\/\\b", ""), "a/b")
assert.Equal(t, GetNormalizedAbsolutePath("a\\b//c", ""), "a/b/c")
assert.Equal(t, GetNormalizedAbsolutePath("\\a\\b\\\\c", ""), "/a/b/c")
assert.Equal(t, GetNormalizedAbsolutePath("\\\\a\\b\\\\c", ""), "//a/b/c")
}

func TestGetRelativePathToDirectoryOrUrl(t *testing.T) {
t.Parallel()
// !!!
Expand Down
Loading