Skip to content

Maybe fix parent setting race #1244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jakebailey wants to merge 2 commits into from
Closed

Maybe fix parent setting race #1244

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95677a7
Maybe fix parent setting race
jakebailey Jun 20, 2025
09579f8
Update internal/binder/binder.go
jakebailey Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/binder/binder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,7 +584,7 @@ func (b *Binder) bind(node *ast.Node) bool {
if node == nil {
return false
}
if node.Parent == nil || node.Parent.Flags&ast.NodeFlagsReparsed != 0 {
if node.Parent == nil || node.Parent != b.parent && node.Parent.Flags&ast.NodeFlagsReparsed != 0 {
node.Parent = b.parent
}
saveInStrictMode := b.inStrictMode
Expand Down