fix(1196): extend parameter matching with index fallback when name matching fails #1241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
reviewed
Jun 19, 2025
...lines/reference/submoduleAccepted/conformance/paramTagNestedWithoutTopLevelObject.types.diff
Outdated
Show resolved
Hide resolved
jakebailey
reviewed
Jun 19, 2025
testdata/baselines/reference/submoduleAccepted/compiler/jsdocParamTagInvalid.types.diff
Outdated
Show resolved
Hide resolved
jakebailey
approved these changes
Jun 24, 2025
Member
|
This PR needs a merge from main after other PRs were merged. |
sandersn
approved these changes
Jun 24, 2025
| ->opts5[0] : { help: string; what: { a: string; bad: { idea: string; oh: boolean; };}; unnest: number; } | ||
| ->opts5 : { help: string; what: { a: string; bad: { idea: string; oh: boolean; };}; unnest: number; }[] | ||
| ->0 : 0 | ||
| +>opts5[0].what : { a: string; bad: { idea: string; oh: boolean; }[]; } |
Member
There was a problem hiding this comment.
bad being an array looks correct; I just can't figure out how Strada thought it wasn't
Member
|
Since there's a merge needed, could you also delete the unused |
jakebailey
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1196
Fixes #1225
ℹ️ This patch extends parameter matching by adding a fallback to index-based resolution when JSDoc parameter tag names do not match function parameter names, and also improves handling of nested array literals.
✅ Verification test - jsdocParamTagTypeLiteral