Skip to content
This repository has been archived by the owner on Jun 11, 2020. It is now read-only.

Handle local references in scoped packages #768

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle local references in scoped packages #768

wants to merge 1 commit into from

Conversation

jablko
Copy link
Contributor

@jablko jablko commented Apr 21, 2020

Fixes #737

@jablko jablko mentioned this pull request Apr 21, 2020
Closed
sandersn
sandersn suggested changes Jun 9, 2020
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good fix, but can you add a test and port it to microsoft/DefinitelyTyped-tools?

@jablko jablko mentioned this pull request Aug 27, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sandersn sandersn sandersn requested changes

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh RyanCavanaugh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependency tracking doesn't understand deep references of scoped packages in test
2 participants
@jablko @sandersn