This repository has been archived by the owner on Jun 11, 2020. It is now read-only.
Make CI slow by validating against master definitely typed #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
suggested changes
Dec 13, 2019
| - git clone https://github.com/DefinitelyTyped/DefinitelyTyped ../DefinitelyTyped | ||
|
|
||
| script: | ||
| - npm tes |
There was a problem hiding this comment.
Suggested change
| - npm tes | |
| - npm test |
| - npm run build | ||
| - npm run clean | ||
| - npm run parse | ||
| - npm run check |
There was a problem hiding this comment.
- This isn't very valuable, it mostly just tells you what
@typespackages are superceded by in-package types. - On the other hand, we shouldn't never run it.
- On the third hand, it'll make CI slow.
- Is CI never not slow?
- This is probably the right place to run it.
| - npm run build | ||
| - npm run clean | ||
| - npm run parse | ||
| - npm run check | ||
|
|
There was a problem hiding this comment.
probably should npm run calculate-versions and npm run generate and npm run index.
Note that some of these tasks hit npm (parse, index and maybe generate?)
| - npm tes | ||
| - npm run build | ||
| - npm run clean | ||
| - npm run parse |
There was a problem hiding this comment.
This relies on a cache to avoid querying npm for everything. It is NOT the most reliable cache, and I don't understand travis' caching strategy. You should test to see whether it's running npm info on every @types package for every CI run. If it's not, then you need to make sure that it's correctly running npm info on packages that were recently updated in DT.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This clones DT into a sibling folder, then runs through everything up till deployment on CI