Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for query parameters for POST, PATCH, and PUT requests #375

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ajuanjojjj
Copy link

I noticed that query parameters were only supported for GET and DELETE requests.
However, since some APIs support query parameters for the other methods as well, adding support for them could enhance the versatility of the client.

Fixes #257 and has no known breaking changes.

@ajuanjojjj ajuanjojjj requested review from a team as code owners July 5, 2024 22:30
@ajuanjojjj
Copy link
Author

Rebased for 7ad2a7a

@scerdal
Copy link

scerdal commented Sep 4, 2024

@ivanduplenskikh will this PR be reviewed?

@ajuanjojjj
Copy link
Author

ajuanjojjj commented Sep 4, 2024

@scerdal I dont want to sound overly pessimistic, but the previous PR that this one is based on, #301 , sat there for almost 3 years without a single message from any maintainer.

I'd love to be proven wrong, but I wouldn't bet on it getting merged anytime soon :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for query parameters in create, update and replace calls
2 participants