Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update samples #336

Merged
merged 18 commits into from
Jul 27, 2022
Merged

Update samples #336

merged 18 commits into from
Jul 27, 2022

Conversation

KonstantinTyukalov
Copy link
Contributor

@KonstantinTyukalov KonstantinTyukalov commented Jul 20, 2022 •
edited
Loading

This PR updates All Typed Rest Client samples to help customers clarify usage of this library.

Changelog:

  • Moved all types of samples into separate directories
  • Updated react sample: rewrote using TS + JSX, bumped react-scripts to 5.x version for fix multiple vulnerabilities, added webpack config modification for polyfills
  • Modified running samples scripts

Checklist:

  • Provided changes not breaks CI
  • Provided changes Tested manually

@KonstantinTyukalov KonstantinTyukalov marked this pull request as ready for review July 22, 2022 13:01
@KonstantinTyukalov KonstantinTyukalov requested a review from a team July 22, 2022 13:33
AndreyIvanov42
AndreyIvanov42 approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@AndreyIvanov42 AndreyIvanov42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually. Changes work fine

@KonstantinTyukalov KonstantinTyukalov merged commit 6d7db3b into master Jul 27, 2022
@max-zaytsev max-zaytsev deleted the users/KonstantinTyukalov/fix_samples branch June 28, 2023 14:10
ajuanjojjj pushed a commit to ajuanjojjj/typed-rest-client that referenced this pull request Jul 5, 2024
@KonstantinTyukalov @ajuanjojjj
Update samples (microsoft#336)
15540f6 
* Move react sample to separate directory

* Rewrite react sample

* Update node server sample

* Move basic samples to separate directory

* Update samples script

* Bump react-scripts to 5.0.1

* Update project configuration to run on react-scripts 5

* Add typescript support

* Add description for react sample

* Add notification when server started
@Mhmonicox Mhmonicox mentioned this pull request Sep 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojgasior wojgasior wojgasior approved these changes

@AndreyIvanov42 AndreyIvanov42 AndreyIvanov42 approved these changes

@vmapetr vmapetr vmapetr approved these changes

@alexander-smolyakov alexander-smolyakov alexander-smolyakov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KonstantinTyukalov @alexander-smolyakov @vmapetr @AndreyIvanov42 @wojgasior