export-name: detect export declarations #443
Conversation
Previously, the `export-name` rule would detect an export assignment
like
```
export = Fish;
// or
export default Fish;
```
but it would not detect an export like
```
export { Fish }
```
| @@ -315,6 +315,24 @@ describe('exportNameRule', () : void => { | |||
| ]); | |||
| }); | |||
|
|
|||
| it('when mis-named function is exported in a separate statement', () : void => { | |||
There was a problem hiding this comment.
Good test for the case of complaining. There should also be a corresponding test for the case of the user getting it right, e.g. file.ts having export { file };.
There was a problem hiding this comment.
Added in new commit, good catch!
| @@ -46,26 +46,43 @@ export class Rule extends Lint.Rules.AbstractRule { | |||
| } | |||
| } | |||
|
|
|||
| function isExportedDeclaration(element: ts.Statement): boolean { | |||
There was a problem hiding this comment.
Just a suggestion: you may wish to file issues on https://github.com/ajafff/tsutils to add these there, as they seem useful. Not a blocking issue for this pull request at all.
There was a problem hiding this comment.
You got it: ajafff/tsutils#68 - feel free to comment there if it's not clear or not quite what you expected.
JoshuaKGoldberg
added
the
PR: Waiting for Reviewer
JoshuaKGoldberg
added
Type: Breaking Change
and removed
PR: Waiting for Reviewer
|
Awesome. Technically, this is a breaking change, as it should start flagging violations it wasn't before. |
Previously, the
export-namerule would detect an export assignmentlike
but it would not detect an export like
Fixes #444