feat: support Node.js ES modules via conditional exports #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copies tslib.mjs file from tslib.es6.js. This change should only affect Node when used with ES modules since the .mjs files is referenced only in conditional export and should be safer. Resolves microsoft#81; closes microsoft#84
|
|
Contributor
|
In #121 I included the |
This was referenced Sep 28, 2020
Contributor
|
This is in with #126 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copies tslib.mjs file from tslib.es6.js as part of
preparescript.This change should only affect Node when used with ES modules since the .mjs files is referenced only in conditional export and should be safer.
Resolves #81; closes #84
#87 renames the CJS version to .cjs extension which could potentially break existing bundling/serving tools.
Creating a symbolic link doesn't work since npm package doesn't support it.